Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use rpcMetadata to update http span name #464 #517

Merged
merged 4 commits into from
Jun 4, 2021

Conversation

vmarchaud
Copy link
Member

@vmarchaud vmarchaud commented Jun 4, 2021

Fixes #464 #512

@vmarchaud vmarchaud self-assigned this Jun 4, 2021
@vmarchaud vmarchaud requested a review from a team June 4, 2021 12:55
@dyladan dyladan linked an issue Jun 4, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #517 (08a31f4) into main (6c2378c) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #517   +/-   ##
=======================================
  Coverage   95.37%   95.38%           
=======================================
  Files         147      147           
  Lines        8974     9005   +31     
  Branches      897      898    +1     
=======================================
+ Hits         8559     8589   +30     
- Misses        415      416    +1     
Impacted Files Coverage Δ
...try-instrumentation-express/src/instrumentation.ts 94.16% <0.00%> (-0.71%) ⬇️
...try-instrumentation-restify/src/instrumentation.ts 87.37% <0.00%> (-0.13%) ⬇️
...lemetry-instrumentation-koa/src/instrumentation.ts 97.01% <0.00%> (-0.09%) ⬇️
...opentelemetry-instrumentation-restify/src/types.ts 100.00% <0.00%> (ø)
...telemetry-instrumentation-restify/src/constants.ts 100.00% <0.00%> (ø)
...metry-instrumentation-restify/test/restify.test.ts 99.60% <0.00%> (+<0.01%) ⬆️
...metry-instrumentation-express/test/express.test.ts 99.05% <0.00%> (+<0.01%) ⬆️
...opentelemetry-instrumentation-koa/test/koa.test.ts 99.56% <0.00%> (+<0.01%) ⬆️
...ry-instrumentation-express/test/ignore-all.test.ts 97.50% <0.00%> (+0.03%) ⬆️
...instrumentation-express/test/custom-config.test.ts 99.13% <0.00%> (+0.24%) ⬆️

Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks :)

@dyladan dyladan added the enhancement New feature or request label Jun 4, 2021
@dyladan dyladan merged commit 164f95a into open-telemetry:main Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Express Instrumentation Incorrectly Names Spans for Base URLs Express instrumentation depends on our SDK
2 participants