-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add node:16 to the test matrix #510
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #510 +/- ##
==========================================
- Coverage 95.24% 94.79% -0.45%
==========================================
Files 8 152 +144
Lines 505 9230 +8725
Branches 89 918 +829
==========================================
+ Hits 481 8750 +8269
- Misses 24 480 +456
|
That's interesting. Does anyone have experience with the error in CI? Since we're not caching anything yet in the node:16 runs, I assume it has to do with the underlying node container.
|
Flarna
approved these changes
May 31, 2021
@anuraaga, I reverted |
…trib into chore/add-node-16
johnbley
approved these changes
Jun 11, 2021
vmarchaud
approved these changes
Jun 12, 2021
nata7che
pushed a commit
to helios/opentelemetry-js-contrib
that referenced
this pull request
Jun 13, 2021
Co-authored-by: Valentin Marchaud <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
chown -R 1001:121 "/github/home/.npm"
to fix the cache permissions - npm v7 does not allow root-owned files in cache;karma-webpack
to v4 in some packages because of the peerDep conflict;socket.connect
is more strict with passed params;Adds current node version(16) to the test matrix.