Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: generalize the instrumentation file name #479

Merged
merged 2 commits into from
May 17, 2021

Conversation

rauno56
Copy link
Member

@rauno56 rauno56 commented May 11, 2021

Which problem is this PR solving?

It renames the files containing the instrumentation logic to instrumentation.ts in every package to generalize the folder structure a bit.

Short description of the changes

There was a discussion here that having those unified would be beneficial. I agree with @obecny on that.

@rauno56 rauno56 requested a review from a team May 11, 2021 08:44
@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #479 (4cce391) into main (0040ab8) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #479   +/-   ##
=======================================
  Coverage   95.26%   95.26%           
=======================================
  Files         140      140           
  Lines        8399     8399           
  Branches      815      815           
=======================================
  Hits         8001     8001           
  Misses        398      398           
Impacted Files Coverage Δ
...try-instrumentation-graphql/src/instrumentation.ts 92.30% <ø> (ø)
...elemetry-instrumentation-pg/src/instrumentation.ts 82.29% <ø> (ø)
...node/opentelemetry-instrumentation-pg/src/utils.ts 97.26% <100.00%> (ø)
...ode/opentelemetry-instrumentation-hapi/src/hapi.ts
...entelemetry-instrumentation-mongodb/src/mongodb.ts
...umentation-user-interaction/src/userInteraction.ts
...entelemetry-instrumentation-express/src/express.ts
...entelemetry-instrumentation-winston/src/winston.ts
node/opentelemetry-instrumentation-net/src/net.ts
...metry-instrumentation-aws-lambda/src/aws-lambda.ts
... and 23 more

@rauno56 rauno56 force-pushed the chore/file-names branch from 163c9dc to e4e9f2b Compare May 13, 2021 08:01
@obecny obecny merged commit b7e0bdd into open-telemetry:main May 17, 2021
nozik pushed a commit to helios/opentelemetry-js-contrib that referenced this pull request May 18, 2021
nozik pushed a commit to helios/opentelemetry-js-contrib that referenced this pull request May 18, 2021
nozik pushed a commit to helios/opentelemetry-js-contrib that referenced this pull request May 18, 2021
obecny added a commit that referenced this pull request Jun 8, 2021
* feat: add responseHook config to redis instrumentation

* fix: lint fix

* feat: add responseHook config to redis instrumentation

* fix: lint fix

* chore(deps): update all non-major dependencies (#483)

* chore: generalize the instrumentation file name (#479)

* feat: add responseHook config to graphql instrumentation

* Apply suggestions from code review

Co-authored-by: Bartlomiej Obecny <[email protected]>

* test: add a test for a responseHook that isn't a function

* fix: lint fix

Co-authored-by: WhiteSource Renovate <[email protected]>
Co-authored-by: Rauno Viskus <[email protected]>
Co-authored-by: Bartlomiej Obecny <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants