-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: generalize the instrumentation file name #479
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flarna
reviewed
May 11, 2021
plugins/node/opentelemetry-instrumentation-restify/package.json
Outdated
Show resolved
Hide resolved
vmarchaud
approved these changes
May 13, 2021
Flarna
approved these changes
May 14, 2021
naseemkullah
approved these changes
May 15, 2021
dyladan
approved these changes
May 17, 2021
obecny
approved these changes
May 17, 2021
nozik
pushed a commit
to helios/opentelemetry-js-contrib
that referenced
this pull request
May 18, 2021
nozik
pushed a commit
to helios/opentelemetry-js-contrib
that referenced
this pull request
May 18, 2021
nozik
pushed a commit
to helios/opentelemetry-js-contrib
that referenced
this pull request
May 18, 2021
obecny
added a commit
that referenced
this pull request
Jun 8, 2021
* feat: add responseHook config to redis instrumentation * fix: lint fix * feat: add responseHook config to redis instrumentation * fix: lint fix * chore(deps): update all non-major dependencies (#483) * chore: generalize the instrumentation file name (#479) * feat: add responseHook config to graphql instrumentation * Apply suggestions from code review Co-authored-by: Bartlomiej Obecny <[email protected]> * test: add a test for a responseHook that isn't a function * fix: lint fix Co-authored-by: WhiteSource Renovate <[email protected]> Co-authored-by: Rauno Viskus <[email protected]> Co-authored-by: Bartlomiej Obecny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
It renames the files containing the instrumentation logic to
instrumentation.ts
in every package to generalize the folder structure a bit.Short description of the changes
There was a discussion here that having those unified would be beneficial. I agree with @obecny on that.