feat: add gRPC Census Example #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kelly, Niall <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
=======================================
Coverage 94.47% 94.47%
=======================================
Files 62 62
Lines 3494 3494
Branches 376 376
=======================================
Hits 3301 3301
Misses 193 193 |
added 2 commits
June 4, 2020 21:17
Signed-off-by: Kelly, Niall <[email protected]>
Signed-off-by: Kelly, Niall <[email protected]>
nkelly75
requested review from
bg451,
dyladan,
markwolff,
mayurkale22,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
mayurkale22
approved these changes
Jun 5, 2020
examples/grpc-census-prop/README.md
Outdated
| to propagate context through the `grpc-trace-bin` binary header. | ||
|
|
||
| The same source code is used to run various versions of the client and server. Environment | ||
| variables (set up through `scripts` in [package.json](./package.json) determine the various |
There was a problem hiding this comment.
Suggested change
| variables (set up through `scripts` in [package.json](./package.json) determine the various | |
| variables (set up through `scripts` in [package.json](./package.json)) determine the various |
added 2 commits
June 5, 2020 11:08
Signed-off-by: Kelly, Niall <[email protected]>
Signed-off-by: Kelly, Niall <[email protected]>
markwolff
approved these changes
Jun 8, 2020
dyladan
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kelly, Niall [email protected]
Which problem is this PR solving?
Provide an example that verifies the new propagator-grpc-census-binary propagator.
During the review of PR #39 @mayurkale22 asked whether there was an example to verify the new propagator. This PR is to add that example.
Short description of the changes
The example started out based on the existing
grpc_dynamic_codegenexample - it makes similar gRPC calls. Depending on environment variables, the client and server can be instrumented with either OpenTelemetry (with varying propagators) or OpenCensus. This allows us to test various combinations and understand when the binary propagator is useful.The README contains extra information about the combinations as well as links to sample output (from console exporters).