chore: clean some unused deps #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flarna
reviewed
Apr 22, 2021
Flarna
approved these changes
Apr 22, 2021
rauno56
force-pushed
the
chore/clean-unused-deps
branch
from
df8daee to
35b1eac
Compare
Codecov Report
@@ Coverage Diff @@
## main #437 +/- ##
=======================================
Coverage 96.11% 96.11%
=======================================
Files 21 21
Lines 695 695
Branches 95 95
=======================================
Hits 668 668
Misses 27 27 |
Flarna
reviewed
Apr 22, 2021
vmarchaud
approved these changes
Apr 22, 2021
naseemkullah
approved these changes
Apr 22, 2021
It is mentioned in the `README.md`, but it mentiones other deps which are expected to be installed separately as well.
Probably added there during testing or by mistake.
Co-authored-by: Gerhard Stöbich <[email protected]>
rauno56
force-pushed
the
chore/clean-unused-deps
branch
from
9244116 to
812ad2e
Compare
dyladan
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Net negative PR. Yaay! 🎉
See commit messages. Mainly:
ts-nodewhich is a dep ints-mochaand@opentelemetry/corein plugins, which, I believe is left there from debugging/testing/copy-pasting.Definitely didn't catch all of them especially many occurrences of:
tslint-consistent-codestyleandtslint-microsoft-contribbecause I thought those might be magically loaded or considered somehow,@types/*, because IDEs load those magically,depcheckhelped.