Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove plugins #427

Closed
wants to merge 8 commits into from
Closed

Remove plugins #427

wants to merge 8 commits into from

Conversation

obecny
Copy link
Member

@obecny obecny commented Apr 15, 2021

Which problem is this PR solving?

  • removing plugins
  • removing meta packages
  • updating readme
  • updating examples
  • downgrading karma from ver. 5 to 4 - it doesn't work locally

dyladan and others added 7 commits April 7, 2021 12:46
@dyladan
chore: remove plugins and update docs references
ffe9969
@seemk @obecny
refactor(net): remove hardcoded values, use semantic conventions (ope…
fcdbb76 
…n-telemetry#414)

* refactor: remove hardcoded values, use semantic conventions

* fix: revert deps version change
@obecny @vmarchaud
chore: fixing context propagation on mongo callback (open-telemetry#403)
fdea890 
Co-authored-by: Valentin Marchaud <[email protected]>
@renovate-bot @obecny @vmarchaud
chore(deps): update dependency karma-webpack to v5 (open-telemetry#334)
65ed832 
Co-authored-by: Bartlomiej Obecny <[email protected]>
Co-authored-by: Valentin Marchaud <[email protected]>
@renovate-bot @obecny
chore(deps): update dependency sinon to v10 (open-telemetry#397)
a5a19b5
@obecny
feat: add instrumentation of AWS Lambda handlers to generate FaaS spa…
a97bd46 
…ns (open-telemetry#399)

Co-authored-by: Bartlomiej Obecny <[email protected]>
@obecny
chore: updating readme, versions, examples, fixing karma - have to do…
ab69461 
…wngrade
@obecny obecny self-assigned this Apr 15, 2021
@obecny obecny requested a review from a team April 15, 2021 19:30
@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #427 (b2615ba) into main (73b9c6b) will not change coverage.
The diff coverage is n/a.

❗ Current head b2615ba differs from pull request most recent head 7e12dbb. Consider uploading reports for the commit 7e12dbb to get more accurate results

@@           Coverage Diff           @@
##             main     #427   +/-   ##
=======================================
  Coverage   94.21%   94.21%           
=======================================
  Files          12       12           
  Lines         432      432           
  Branches       48       48           
=======================================
  Hits          407      407           
  Misses         25       25

@vmarchaud
Copy link
Member

I think the history is brokee, there are commit from main on the PR :/

vmarchaud
vmarchaud reviewed Apr 16, 2021
View reviewed changes
Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just need to fix history

@rauno56 rauno56 mentioned this pull request Apr 16, 2021
Merged
@obecny
Copy link
Member Author

obecny commented Apr 16, 2021

lgtm, just need to fix history

I had cherry picked the changes and created new PR -> #429

@obecny obecny closed this Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flarna Flarna Flarna left review comments

@vmarchaud vmarchaud vmarchaud left review comments

Assignees

@obecny obecny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@obecny @vmarchaud @Flarna @dyladan @seemk @renovate-bot