-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: winston instrumentation #425
Conversation
Codecov Report
@@ Coverage Diff @@
## main #425 +/- ##
=======================================
Coverage 95.83% 95.83%
=======================================
Files 15 15
Lines 624 624
Branches 94 94
=======================================
Hits 598 598
Misses 26 26 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice piece of work, thx for contribution
Would you be able to include the screenshots to show how the spans look like, can be in this or separate PR ?
Perhaps I understood the question wrong, but the instrumentation itself does not generate spans, only injects the active span context to log records. E.g. an example:
|
Which problem is this PR solving?
Similarly to bunyan (#419), adds trace context to log metadata fields.
Short description of the changes
Injects
trace_id
,span_id
,trace_flags
to winston log metadata.Note that testing with older winston versions (
1.1.2
and2.4.4
) was done manually. To help with testing in the future, see open-telemetry/opentelemetry-js#2110