-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: creating meta package for default auto instrumentations for node #379
Conversation
@open-telemetry/javascript-approvers this is basically complete but without tests, please have a look before I start adding unit tests |
Codecov Report
@@ Coverage Diff @@
## main #379 +/- ##
==========================================
+ Coverage 93.88% 94.34% +0.46%
==========================================
Files 12 10 -2
Lines 409 407 -2
Branches 44 44
==========================================
Hits 384 384
+ Misses 25 23 -2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, just have a suggestion for a way to lower the number of places that need to be updated when we add a package.
* chore: use one map to manage instrumentation types * chore: lint * chore: use default config * chore: merge configs * style: no any * chore: infer config type * style: lint * style: no any * chore: export config map type * chore: bring back deleted debug log
@obecny Do you want to wait for mysql plugin to release this ? |
it all depends when the mysql will be merged / done |
Which problem is this PR solving?
Short description of the changes
Usage