Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User interaction instrumentation #324

Merged
merged 8 commits into from
Feb 2, 2021

Conversation

obecny
Copy link
Member

@obecny obecny commented Jan 27, 2021

Which problem is this PR solving?

Short description of the changes

  • Converting user interaction plugin to instrumentation
  • adding example

@obecny obecny added the enhancement New feature or request label Jan 27, 2021
@obecny obecny requested a review from a team January 27, 2021 16:13
@obecny obecny self-assigned this Jan 27, 2021
@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #324 (d082c1f) into main (9d7446d) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
- Coverage   95.48%   95.47%   -0.02%     
==========================================
  Files         119      119              
  Lines        6273     6277       +4     
  Branches      609      614       +5     
==========================================
+ Hits         5990     5993       +3     
- Misses        283      284       +1     
Impacted Files Coverage Δ
...opentelemetry-plugin-user-interaction/.eslintrc.js
...entelemetry-plugin-user-interaction/src/version.ts
...lugin-user-interaction/src/enums/AttributeNames.ts
...try-plugin-user-interaction/src/userInteraction.ts
...etry-instrumentation-user-interaction/.eslintrc.js 0.00% <0.00%> (ø)
...umentation-user-interaction/src/userInteraction.ts 93.86% <0.00%> (ø)
...ation-user-interaction/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...ry-instrumentation-user-interaction/src/version.ts 100.00% <0.00%> (ø)

Copy link
Member

@johnbley johnbley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Base automatically changed from master to main January 27, 2021 22:21
@obecny obecny merged commit 9336cdc into open-telemetry:main Feb 2, 2021
@obecny
Copy link
Member Author

obecny commented Feb 2, 2021

strange it didn't close at first when merging

@obecny obecny deleted the user_interaction branch February 2, 2021 11:57
@obecny obecny changed the title User interaction User interaction instrumentation Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert user-interaction plugin to instrumentation
4 participants