fix: avoid races because of parallel ioredis tests #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioredis tests run parallel for serverl node versions using the same redis instance. Add a random part to keys to avoid that one run impacts others. Additionally improve lua test asserts as the script may be already cached by redis resulting in one span less.
dyladan
approved these changes
Jan 13, 2021
|
I was just working on this haha |
Codecov Report
@@ Coverage Diff @@
## master #303 +/- ##
==========================================
- Coverage 95.44% 95.39% -0.05%
==========================================
Files 115 115
Lines 6055 6061 +6
Branches 590 591 +1
==========================================
+ Hits 5779 5782 +3
- Misses 276 279 +3
|
naseemkullah
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ioredis tests run parallel for serverl node versions using the same redis instance.
Add a random part to keys to avoid that one run impacts others.
Additionally improve lua test asserts as the script may be already cached by redis resulting in one span less.