-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add instrumentation-dns #302
feat: add instrumentation-dns #302
Conversation
port plugin-dns to instrumenation API because the plugin API will be removed from OTel.
Codecov Report
@@ Coverage Diff @@
## main #302 +/- ##
==========================================
- Coverage 95.29% 95.02% -0.27%
==========================================
Files 124 135 +11
Lines 6690 7192 +502
Branches 639 672 +33
==========================================
+ Hits 6375 6834 +459
- Misses 315 358 +43
|
plugins/node/opentelemetry-instrumentation-dns/test/integrations/dns-lookup.test.ts
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-dns/src/enums/AttributeNames.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
port plugin-dns to instrumenation API because the plugin API will be removed from OTel.
fixes: #253