Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OpenTelemetry SDK 0.8.x #30

Merged
merged 10 commits into from
May 29, 2020

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented May 13, 2020

No description provided.

@mayurkale22
Copy link
Member

Would be nice if you can update examples too.

@justinwalz
Copy link

Hi all, a polite bump on this PR? I'm unable to use the latest otel releases as propagator jaeger is still pinned on context-base v0.6.x

Types have separate declarations of a private property '_currentContext'

Let me know if I can help out at all.

@dyladan
Copy link
Member Author

dyladan commented May 18, 2020

I am going to update this today as we just actually released 0.8.1. It will be released probably tomorrow or wednesday. Is that ok?

@justinwalz
Copy link

That's perfect, no rush. Thank you!

@justinwalz
Copy link

Hey @dyladan I noticed 0.8.2 was released. Just wanted to ping a reminder here, just in case it got lost in the shuffle. Best, Justin

@dyladan
Copy link
Member Author

dyladan commented May 26, 2020

Sorry @justinwalz I'll get to this tomorrow hopefully.

@dyladan
Copy link
Member Author

dyladan commented May 29, 2020

@markwolff any idea why pg is failing again here?

edit: nevermind I found it c04ed24

@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #30 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   94.32%   94.32%   -0.01%     
==========================================
  Files          57       57              
  Lines        3295     3294       -1     
  Branches      351      351              
==========================================
- Hits         3108     3107       -1     
  Misses        187      187              
Impacted Files Coverage Δ
.../opentelemetry-plugin-pg-pool/test/pg-pool.test.ts 88.46% <100.00%> (ø)
...ugins/node/opentelemetry-plugin-pg/test/pg.test.ts 93.99% <100.00%> (-0.03%) ⬇️

@dyladan dyladan added the enhancement New feature or request label May 29, 2020
@dyladan dyladan changed the title chore: bump otel dependencies to 0.8.0 Support OpenTelemetry SDK 0.8.x May 29, 2020
@dyladan dyladan merged commit e47397f into open-telemetry:master May 29, 2020
@dyladan dyladan deleted the bump-8 branch May 29, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants