Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixing parent span for graphql #299

Merged
merged 2 commits into from
Jan 8, 2021

Conversation

obecny
Copy link
Member

@obecny obecny commented Jan 5, 2021

Which problem is this PR solving?

Short description of the changes

  • Fixes the parent span for main spans

@obecny obecny added the bug Something isn't working label Jan 5, 2021
@obecny obecny self-assigned this Jan 5, 2021
@obecny obecny requested a review from a team January 5, 2021 00:16
@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #299 (915b5bb) into master (e3de6ba) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #299   +/-   ##
=======================================
  Coverage   95.33%   95.33%           
=======================================
  Files         115      115           
  Lines        5998     5965   -33     
  Branches      592      588    -4     
=======================================
- Hits         5718     5687   -31     
+ Misses        280      278    -2     
Impacted Files Coverage Δ
...entelemetry-instrumentation-graphql/src/symbols.ts 100.00% <ø> (ø)
...entelemetry-instrumentation-graphql/src/graphql.ts 92.14% <100.00%> (+0.75%) ⬆️
...opentelemetry-instrumentation-graphql/src/types.ts 100.00% <100.00%> (ø)
...metry-instrumentation-graphql/test/graphql.test.ts 100.00% <100.00%> (ø)

@obecny obecny merged commit 7770109 into open-telemetry:master Jan 8, 2021
@obecny obecny deleted the graphql_294 branch January 8, 2021 18:34
@chrisdostert
Copy link

Awesome contribution; i've been seeing this as well. Is it possible to get a release cut?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Many graphql.execute spans have the same parent span id
5 participants