Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix links to examples #290

Merged
merged 2 commits into from
Dec 28, 2020

Conversation

aabmass
Copy link
Member

@aabmass aabmass commented Dec 21, 2020

Which problem is this PR solving?

  • Fix broken link in docs

Short description of the changes

A few packages were linking to opentelemetry-js core repo, but this package has moved to contrib. The web-tracing example is still in core repo.

@aabmass aabmass force-pushed the fix-express-example branch from 163a271 to d76a5db Compare December 21, 2020 20:07
@aabmass aabmass changed the title chore: fix link to express example docs: fix links to examples Dec 21, 2020
@aabmass aabmass force-pushed the fix-express-example branch from d76a5db to 8bd257f Compare December 21, 2020 20:11
@aabmass aabmass marked this pull request as ready for review December 21, 2020 20:13
@aabmass aabmass requested a review from a team December 21, 2020 20:13
@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #290 (1dd1e6b) into master (666fbf6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #290   +/-   ##
=======================================
  Coverage   95.32%   95.32%           
=======================================
  Files         115      115           
  Lines        5948     5948           
  Branches      586      586           
=======================================
  Hits         5670     5670           
  Misses        278      278           

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@obecny obecny added the bug Something isn't working label Dec 22, 2020
@obecny obecny merged commit 5dddf1d into open-telemetry:master Dec 28, 2020
@aabmass aabmass deleted the fix-express-example branch December 28, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants