Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to OTel v0.14.0 #283

Merged
merged 2 commits into from
Dec 18, 2020

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Dec 17, 2020

Update all dependencies to 0.14.0 and adapt code to changed APIs.

Most changes are straight forward. But it was needed to adapt the opentelemetry-host-metrics/test/metric.test as it seems the data is now in second export. Don't know if this is expected.

Update all dependencies to 0.14.0 and adapt code to changed APIs.
@Flarna Flarna requested a review from a team December 17, 2020 23:45
@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #283 (b60161e) into master (19f4319) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #283   +/-   ##
=======================================
  Coverage   95.32%   95.32%           
=======================================
  Files         115      115           
  Lines        5948     5948           
  Branches      586      586           
=======================================
  Hits         5670     5670           
  Misses        278      278           
Impacted Files Coverage Δ
packages/opentelemetry-host-metrics/src/metric.ts 100.00% <ø> (ø)
...ges/opentelemetry-host-metrics/test/metric.test.ts 96.52% <100.00%> (ø)
plugins/node/opentelemetry-plugin-pg/src/utils.ts 98.43% <100.00%> (ø)
...ns/node/opentelemetry-plugin-pg/test/utils.test.ts 98.36% <100.00%> (ø)
node/opentelemetry-plugin-express/src/types.ts 100.00% <0.00%> (ø)
...telemetry-plugin-document-load/src/documentLoad.ts 97.93% <0.00%> (ø)

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine. I have checked the metrics and here are the findings.

Please check line 118 of metric.test.ts
and change this line into
sandbox.clock.tick(INTERVAL * 1); ("1")
it will run once only , I have discovered that when it has 2 it timeouts for 1st one and thats why the values are from 2nd run
You will have to just update the values when comparing them because they will have now 1 cycle (which is correct, haven't spotted that before). and now it seems that batch is running for 1st time too.

@obecny
Copy link
Member

obecny commented Dec 18, 2020

@Flarna if you can fix just this tests for metrics, I would like to make a release propose of contrib repo today yet ...

@Flarna
Copy link
Member Author

Flarna commented Dec 18, 2020

@obecny I tried that but the test still fails but now the expected values differ. e.g.

  1) Host Metrics
       should export CPU time metrics:

      AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected

+ 0.842204
- 3.8422039999999997

@Flarna
Copy link
Member Author

Flarna commented Dec 18, 2020

adapted the values. seems this was just a side effect of the measurement interval so depending on how aggregation is done it was needed to remove 3 seconds, divide values by two or adapt to round-off errors.

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@obecny obecny merged commit 3135451 into open-telemetry:master Dec 18, 2020
@Flarna Flarna deleted the otel-v0.14.0 branch December 18, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants