-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to OTel v0.14.0 #283
chore: update to OTel v0.14.0 #283
Conversation
Update all dependencies to 0.14.0 and adapt code to changed APIs.
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
=======================================
Coverage 95.32% 95.32%
=======================================
Files 115 115
Lines 5948 5948
Branches 586 586
=======================================
Hits 5670 5670
Misses 278 278
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks fine. I have checked the metrics and here are the findings.
Please check line 118 of metric.test.ts
and change this line into
sandbox.clock.tick(INTERVAL * 1);
("1")
it will run once only , I have discovered that when it has 2 it timeouts for 1st one and thats why the values are from 2nd run
You will have to just update the values when comparing them because they will have now 1 cycle (which is correct, haven't spotted that before). and now it seems that batch is running for 1st time too.
@Flarna if you can fix just this tests for metrics, I would like to make a release propose of contrib repo today yet ... |
@obecny I tried that but the test still fails but now the expected values differ. e.g.
|
adapted the values. seems this was just a side effect of the measurement interval so depending on how aggregation is done it was needed to remove 3 seconds, divide values by two or adapt to round-off errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Update all dependencies to 0.14.0 and adapt code to changed APIs.
Most changes are straight forward. But it was needed to adapt the opentelemetry-host-metrics/test/metric.test as it seems the data is now in second export. Don't know if this is expected.