fix(koa): End span and record exception on a middleware exception #281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #279
Not sure why the lint task failed, I did run
npm run lint:fix
prior to comitting.Which problem is this PR solving?
This PR fixes the problem where
.end()
is never called on the span for a middleware layer when the middleware layer throws an exception / rejects a promise.The master branch fails on the test case that I added.
Short description of the changes
span.end()
for the span that's created for a middleware layer. Also record the exception in the span (as an event), then rethrow it so the application can handle it.I considered using the
safeExecuteInTheMiddle
utility function, but it doesn't look like it works well with async functions.