-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(detector-aws): remove semconv incubating import #2668
base: main
Are you sure you want to change the base?
Conversation
d0e8d43
to
f3bdacf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2668 +/- ##
==========================================
+ Coverage 90.80% 90.84% +0.03%
==========================================
Files 170 171 +1
Lines 8070 8102 +32
Branches 1646 1646
==========================================
+ Hits 7328 7360 +32
Misses 742 742
|
af088df
to
f40da84
Compare
f40da84
to
af088df
Compare
@garysassano Thanks. Heads up that I pushed a couple of commits to your feature branch. Happy to discuss the changes:
|
I would have preferred using |
Which problem is this PR solving?
The AWS detectors are directly importing experimental attributes from
@opentelemetry/semantic-conventions/incubating
, which can lead to breaking changes in minor versions and increased disk usage due to having multiple package versions installed.Short description of the changes
/src/semconv.ts
file with generated unstable semantic conventions/src/semconv.ts
fileThis follows the OpenTelemetry best practices for handling unstable semantic conventions.