Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(instrumentation-pg): use done on test #2478

Merged
merged 1 commit into from
Oct 11, 2024
Merged

chore(instrumentation-pg): use done on test #2478

merged 1 commit into from
Oct 11, 2024

Conversation

maryliag
Copy link
Contributor

Which problem is this PR solving?

  • Trying to solve the flakiness of the test

@maryliag maryliag requested a review from a team as a code owner October 11, 2024 14:05
@maryliag maryliag mentioned this pull request Oct 11, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Oct 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.74%. Comparing base (25ab243) to head (6ec4b37).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2478   +/-   ##
=======================================
  Coverage   90.74%   90.74%           
=======================================
  Files         156      156           
  Lines        7723     7723           
  Branches     1588     1588           
=======================================
  Hits         7008     7008           
  Misses        715      715

trentm
trentm approved these changes Oct 11, 2024
View reviewed changes
plugins/node/opentelemetry-instrumentation-pg/test/pg-pool.test.ts
@@ -563,6 +563,7 @@ describe('pg-pool', () => {
0,
'expected to have 0 pending requests'
);
done();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this is a clearer fix.
I have a similar fix for this test failure here: https://github.com/open-telemetry/opentelemetry-js-contrib/pull/2464/files?diff=unified&w=1#diff-682483846290c7e14fba934e5f5effaaa2ff8e84e94f511300af6d0120a59251R495-R570
as part of a larger PR

@trentm trentm merged commit d08d50d into open-telemetry:main Oct 11, 2024
19 checks passed
@maryliag maryliag deleted the fix-test branch October 11, 2024 17:26
@trentm
Copy link
Contributor

trentm commented Oct 11, 2024 •
edited
Loading

@maryliag I just now noticed your comment on my other PR: #2464 (comment)

But got the same issue.

Hrm, I had thought that that change made the issue go away. I haven't yet seen that error happen after this change (your version or mine). We shall see if it comes up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphael-theriault-swi raphael-theriault-swi raphael-theriault-swi approved these changes

@trentm trentm trentm approved these changes

Assignees

@maryliag maryliag

Labels
pkg:instrumentation-pg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maryliag @trentm @raphael-theriault-swi