Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(instrumentation-fastify): mark instrumentation as unmaintained #2452

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

I had initially picked up ownership for the fastify instrumentation package from a previously unknown owner to keep it alive for a bit longer in case we were to go ahead and remove unmaintained packages.

However, with all the other responsibilities that come with maintaining the JS SIGs two repositories (https://github.com/open-telemetry/opentelemetry-js-contrib, https://github.com/open-telemetry/opentelemetry-js), I don't have a lot of time to dedicate to this instrumentation as other things tend to be higher priority (handling releases, issues, fixing bugs in core components, general repo maintenance). As such, with me as an owner, the instrumentation is effectively unmaintained as I never find enough time to actually work on it. Therefore this PR removes me as an owner to bring more visibility to the fact that this instrumentation is essentially owner-less.

@pichlermarc pichlermarc requested a review from a team as a code owner September 25, 2024 09:23
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.77%. Comparing base (dfb2dff) to head (630f267).
Report is 246 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2452      +/-   ##
==========================================
- Coverage   90.97%   90.77%   -0.21%     
==========================================
  Files         146      156      +10     
  Lines        7492     7716     +224     
  Branches     1502     1584      +82     
==========================================
+ Hits         6816     7004     +188     
- Misses        676      712      +36     

see 76 files with indirect coverage changes

@pichlermarc pichlermarc merged commit 7898458 into open-telemetry:main Sep 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants