fix: update references to logging exporter #2441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037 Signed-off-by: Alex Boten <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2441 +/- ##
==========================================
- Coverage 90.97% 90.77% -0.21%
==========================================
Files 146 156 +10
Lines 7492 7716 +224
Branches 1502 1584 +82
==========================================
+ Hits 6816 7004 +188
- Misses 676 712 +36 |
|
Thanks. Do you think we'll also need to update the version from otel/opentelemetry-collector-contrib:0.61.0. I'm guessing that version in ancient at this point. |
trentm
added a commit
to trentm/opentelemetry-js-contrib
that referenced
this pull request
Oct 8, 2024
- drop Jaeger from examples (given open-telemetry/opentelemetry-specification#3551) - update otel-collector-contib version and switch from logging to debug exporter (lifted from open-telemetry#2441) - various other small fixes to get the README steps basically working
I found it was necessary to update, along with a number of other changes to get the example to work. |
|
Closing in favour of #2465 |
trentm
added a commit
that referenced
this pull request
Oct 11, 2024
- drop Jaeger from examples (given open-telemetry/opentelemetry-specification#3551) - update otel-collector-contib version and switch from logging to debug exporter (lifted from #2441) - various other small fixes to get the README steps basically working Refs: #2441
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037