-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: test with Node.js 22 #2350
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2350 +/- ##
==========================================
- Coverage 90.97% 90.40% -0.58%
==========================================
Files 146 149 +3
Lines 7492 7359 -133
Branches 1502 1527 +25
==========================================
- Hits 6816 6653 -163
- Misses 676 706 +30 |
Now I re-added all the pkg: labels to get a full TAV test run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great - all tests are passing, thank you for working on this 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the detailed notes around the test changes. I think the overall benefit of this test is enough to move forward in merging. If anything a TODO could be added to the test linking back to this for a later investigation, but I don't see it being worthwhile enough to keep digging into the polling behavior.
It is long past time to be testing with Node.js 22.
The core repo is already doing so (as of open-telemetry/opentelemetry-js#4666).