Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: test on node 14 #23

Merged
merged 4 commits into from
Sep 9, 2020
Merged

chore: test on node 14 #23

merged 4 commits into from
Sep 9, 2020

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented May 4, 2020

Fixes #22

@codecov-io
Copy link

codecov-io commented May 4, 2020 •
edited by codecov bot
Loading

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   95.21%   95.21%           
=======================================
  Files          92       92           
  Lines        4723     4723           
  Branches      488      488           
=======================================
  Hits         4497     4497           
  Misses        226      226

obecny
obecny approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we keep 13 until 2020-06-01 ?

@dyladan
Copy link
Member Author

dyladan commented May 4, 2020

hmm @mayurkale22 wdyt? AFAIK 13 essentially is 14, but with the API not completely finalized yet. Obviously there are differences though since our tests are passing in 13 but not 14.

@mayurkale22
Copy link
Member

hmm @mayurkale22 wdyt? AFAIK 13 essentially is 14, but with the API not completely finalized yet. Obviously there are differences though since our tests are passing in 13 but not 14.

Maybe we can keep both and remove 13 after 2020-06-01?

@dyladan
Copy link
Member Author

dyladan commented May 5, 2020

I will update the PR, and will make a PR to have same behavior in core. We still need to figure out why pg fails on 14

@markwolff markwolff mentioned this pull request Jun 9, 2020
Merged
@naseemkullah naseemkullah mentioned this pull request Aug 29, 2020
Closed
@obecny
Copy link
Member

obecny commented Sep 7, 2020

@dyladan can you please resolve conflicts ?

@dyladan
Copy link
Member Author

dyladan commented Sep 9, 2020

@dyladan can you please resolve conflicts ?

I'll do this today

@dyladan dyladan requested a review from a team September 9, 2020 13:18
@dyladan dyladan merged commit 7816773 into open-telemetry:master Sep 9, 2020
@Flarna Flarna deleted the node-14 branch January 22, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naseemkullah naseemkullah naseemkullah approved these changes

@mayurkale22 mayurkale22 mayurkale22 approved these changes

@obecny obecny obecny approved these changes

@bg451 bg451 Awaiting requested review from bg451

@markwolff markwolff Awaiting requested review from markwolff

@OlivierAlbertini OlivierAlbertini Awaiting requested review from OlivierAlbertini

@rochdev rochdev Awaiting requested review from rochdev

@vmarchaud vmarchaud Awaiting requested review from vmarchaud

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build: Use node 14 instead of node 13
5 participants
@dyladan @codecov-io @mayurkale22 @obecny @naseemkullah