-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: permanently deprecate opentelemetry-browser-extension-autoinjection #2285
chore: permanently deprecate opentelemetry-browser-extension-autoinjection #2285
Conversation
…ction Signed-off-by: svrnm <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2285 +/- ##
==========================================
- Coverage 90.97% 90.30% -0.68%
==========================================
Files 146 147 +1
Lines 7492 7263 -229
Branches 1502 1509 +7
==========================================
- Hits 6816 6559 -257
- Misses 676 704 +28 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the update.
Happy to hear that there's a third-party replacement for the package. 🙂
Thanks @svrnm @open-telemetry/android-maintainers do you think we should keep the deprecated package in this repo? |
@blumamir I think we should keep the README.md to tell people where to go to find the replacement. 🙂 |
I'm a bit confused, is it related to an android package? |
@blumamir must've pinged the wrong group. I think he meant @open-telemetry/javascript-maintainers 🙂 |
yes, my bad. sorry about that :) |
I am OK with both, but I would prefer to keep it |
I see a bit of "why not both" here. If we keep the README, we can also include a link to the code (say from a previous tag) and remove the code from main. Another alternative is to - whether now or later - create a separate markdown file linked from the main README that includes an index (list) of deprecated/archived projects like this one, i.e. |
I like that (doing it incrementally + having a deprecated.md that points to the commit with the code). I know that JS SIG is not the only one looking into that, I wonder how other SIGs are handling that? |
I support removing the code (which one can also find in git by checking out to an early commit) and leaving just a note in the README to communicate the status so that it won't go away for some reasonable time. The code pops up in IDE searches and may still promote old practices which I don't see any good reason to keep anymore. |
@blumamir @pichlermarc @JamieDanielson whatever you prefer doing I can implement via this PR, or feel free to go ahead and raise one separately to get this fixed |
Thanks 👍 |
As discussed in #1152 (comment) this PR will permanently deprecate the OpenTelemetry Browser Extension in this repository. While this was not a lighthearted decision, I think it is the right thing to do, since it
In this PR I make sure that it is clear that this is permanent, but that there are alternatives and that they can be found via the Registry (and people can add more if they want to)
@SimenB I appreciate the help you provided on fixing and debugging the underlying issue with webpack4&webpack5 and I apologize that this didn't land
Note, that I kicked off a conversation with @tbrockman about the extension at https://github.com/tbrockman/opentelemetry-browser-extension and shared some if the ideas I had for the extension. I also played around with this extension and it is much feature-richer and stable than what I created, so at the end this is a happy ending!
Thank you all