-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to webpack 5 #2269
chore: update to webpack 5 #2269
Conversation
df2cdf4
to
8d5457b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2269 +/- ##
==========================================
- Coverage 90.97% 90.30% -0.67%
==========================================
Files 146 147 +1
Lines 7492 7234 -258
Branches 1502 1500 -2
==========================================
- Hits 6816 6533 -283
- Misses 676 701 +25 |
FYI @JamieDanielson - this is the PR we talked about offline, updates to webpack@5 to align the repo with what we have in core. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exciting! Thanks for looking into this ⭐
…or packages Also add mocha to the top-level devDeps. This had a huge impact on the package-lock layout: instead of a mocha install in EVERY workspace subfolder, we get one at the top. This also resolves some errors in `npm ls` currently on main, that were introduced in open-telemetry#2269, e.g.: ``` $ npm ls ├─┬ @opentelemetry/[email protected] -> ./propagators/opentelemetry-propagator-instana │ ├── @types/[email protected] invalid: "10.0.20" from propagators/opentelemetry-propagator-instana │ ├── [email protected] invalid: "3.1.0" from propagators/opentelemetry-propagator-instana ... ├─┬ @opentelemetry/[email protected] -> ./propagators/opentelemetry-propagator-ot-trace │ ├── @types/[email protected] invalid: "10.0.20" from propagators/opentelemetry-propagator-ot-trace ... ```
Updates webpack and configs to align with the setup in core, aims to unblock #1152