Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to webpack 5 #2269

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Jun 7, 2024

Updates webpack and configs to align with the setup in core, aims to unblock #1152

@pichlermarc pichlermarc force-pushed the chore/update-webpack-and-karma branch from df2cdf4 to 8d5457b Compare June 7, 2024 13:14
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.30%. Comparing base (dfb2dff) to head (19d006c).
Report is 156 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2269      +/-   ##
==========================================
- Coverage   90.97%   90.30%   -0.67%     
==========================================
  Files         146      147       +1     
  Lines        7492     7234     -258     
  Branches     1502     1500       -2     
==========================================
- Hits         6816     6533     -283     
- Misses        676      701      +25     

see 56 files with indirect coverage changes

@pichlermarc pichlermarc marked this pull request as ready for review June 10, 2024 12:27
@pichlermarc pichlermarc requested a review from a team June 10, 2024 12:27
@pichlermarc
Copy link
Member Author

FYI @JamieDanielson - this is the PR we talked about offline, updates to webpack@5 to align the repo with what we have in core. 🙂

Copy link
Member

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting! Thanks for looking into this ⭐

@pichlermarc pichlermarc merged commit caf7cb5 into open-telemetry:main Jun 11, 2024
13 checks passed
trentm added a commit to trentm/opentelemetry-js-contrib that referenced this pull request Oct 21, 2024
…or packages

Also add mocha to the top-level devDeps. This had a huge impact on the
package-lock layout: instead of a mocha install in EVERY workspace
subfolder, we get one at the top.

This also resolves some errors in `npm ls` currently on main, that
were introduced in open-telemetry#2269, e.g.:

```
$ npm ls
├─┬ @opentelemetry/[email protected] -> ./propagators/opentelemetry-propagator-instana
│ ├── @types/[email protected] invalid: "10.0.20" from propagators/opentelemetry-propagator-instana
│ ├── [email protected] invalid: "3.1.0" from propagators/opentelemetry-propagator-instana
...
├─┬ @opentelemetry/[email protected] -> ./propagators/opentelemetry-propagator-ot-trace
│ ├── @types/[email protected] invalid: "10.0.20" from propagators/opentelemetry-propagator-ot-trace
...
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment