-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Graphql #226
feature: Graphql #226
Conversation
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
==========================================
- Coverage 95.26% 95.06% -0.20%
==========================================
Files 100 110 +10
Lines 5028 5879 +851
Branches 526 605 +79
==========================================
+ Hits 4790 5589 +799
- Misses 238 290 +52
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already reviewed this when the PR was open in the main repo but I'll put the same comment here.
I'm not familiar with the graphql module's API, but it seems like a generally straightforward implementation of the tracing and the use of the new instrumentation module looks good to me. Approving.
@obecny Thanks a lot for this. Just looked up on NPM and I am not able to find the package Also, does this support Apollo Federation? Thanks |
it hasn't been released yet
Not sure, the plugin instruments the graphql core library, so anything that is using that should be instrumented the same. but if certain library does something more beyond the graphql lib then not |
Could we know when this will be released ? Looking forward to try it out ! |
Just saw it published six days ago. |
@obecny any suggestion to debug?, I have all set up done but nothing is traced. |
Please create an issue and fill out all needed information including code samples etc. otherwise it is impossible to tell anything |
Which problem is this PR solving?
Short description of the changes