Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pg spans disconnected from parent #225

Merged
merged 15 commits into from
Oct 28, 2020
Merged

pg spans disconnected from parent #225

merged 15 commits into from
Oct 28, 2020

Conversation

obecny
Copy link
Member

@obecny obecny commented Oct 19, 2020

Which problem is this PR solving?

Short description of the changes

  • Fixing context propagation for koa middleware layer

@obecny obecny requested a review from a team October 19, 2020 13:55
@obecny obecny self-assigned this Oct 19, 2020
@codecov
Copy link

codecov bot commented Oct 19, 2020 •
edited
Loading

Codecov Report

Merging #225 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
+ Coverage   95.22%   95.23%   +0.01%     
==========================================
  Files          92       92              
  Lines        4755     4767      +12     
  Branches      492      492              
==========================================
+ Hits         4528     4540      +12     
  Misses        227      227
Impacted Files Coverage Δ
.../node/opentelemetry-koa-instrumentation/src/koa.ts 98.03% <0.00%> (+0.03%) ⬆️
...opentelemetry-koa-instrumentation/test/koa.test.ts 99.16% <0.00%> (+0.08%) ⬆️

@akshah123
Copy link
Contributor

This issue is causing us a lot of grief. It would be great if this PR is merged and the issue fix gets release soon.

mwear
mwear approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@obecny obecny merged commit fa137d5 into open-telemetry:master Oct 28, 2020
@obecny obecny deleted the koa_context branch October 28, 2020 14:37
@obecny obecny added the bug Something isn't working label Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwear mwear mwear approved these changes

@dyladan dyladan dyladan approved these changes

Assignees

@obecny obecny

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pg spans disconnected from parent
4 participants
@obecny @akshah123 @dyladan @mwear