-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add baggage key predicate to baggage span processor #2212
feat: Add baggage key predicate to baggage span processor #2212
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2212 +/- ##
==========================================
+ Coverage 90.97% 95.12% +4.14%
==========================================
Files 146 10 -136
Lines 7492 697 -6795
Branches 1502 143 -1359
==========================================
- Hits 6816 663 -6153
+ Misses 676 34 -642 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is very much needed. Thank you for working on this.
Added few comments
@blumamir I've updated the PR to make the predicate a required parameter, and make some of the suggested changes. Please take a look 👍🏻 |
…elemetry-js-contrib into mike/baggage-predicate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for addressing my comments, this feature looks great 🥇
Added one last comment on sending a config
object in the constructor
Thanks @blumamir ! |
Which problem is this PR solving?
Short description of the changes