-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wrapper function for hapi route & plugins #221
fix: wrapper function for hapi route & plugins #221
Conversation
|
Codecov Report
@@ Coverage Diff @@
## master #221 +/- ##
==========================================
+ Coverage 95.21% 95.26% +0.04%
==========================================
Files 100 100
Lines 4979 5028 +49
Branches 517 526 +9
==========================================
+ Hits 4741 4790 +49
Misses 238 238
|
plugins/node/opentelemetry-hapi-instrumentation/test/hapi-plugin.test.ts
Outdated
Show resolved
Hide resolved
@obecny I have pushed up the changes. Can I get another review please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Hi @obecny Just wondering what's the ETA on this getting merged? Would love to get this merged. Our org is using the forked version of the hapi plugin right now. |
@open-telemetry/javascript-approvers ^^ |
@jk1z I can't merge this until you update the branch (or check the box that allows maintainers to update your branch 😄 ) |
That's done. 🙏 |
Which problem is this PR solving?
Short description of the changes