Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instrumentation-runtime-node)!: add prom-client-metrics #2136

Merged
merged 38 commits into from
Nov 5, 2024

Merge branch 'main' into feat/node/prom-client-implementation

4941407
Select commit
Loading
Failed to load commit list.
Merged

feat(instrumentation-runtime-node)!: add prom-client-metrics #2136

Merge branch 'main' into feat/node/prom-client-implementation
4941407
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 5, 2024 in 0s

90.79% (-0.07%) compared to 6234918

View this Pull Request on Codecov

90.79% (-0.07%) compared to 6234918

Details

Codecov Report

Attention: Patch coverage is 87.70950% with 22 lines in your changes missing coverage. Please review.

Project coverage is 90.79%. Comparing base (6234918) to head (4941407).

Files with missing lines Patch % Lines
...umentation-runtime-node/src/metrics/gcCollector.ts 72.00% 7 Missing ⚠️
...entation-runtime-node/src/metrics/baseCollector.ts 66.66% 4 Missing ⚠️
...untime-node/src/metrics/eventLoopDelayCollector.ts 93.47% 3 Missing ⚠️
...nstrumentation-runtime-node/src/instrumentation.ts 90.00% 2 Missing ⚠️
...runtime-node/src/metrics/eventLoopTimeCollector.ts 90.47% 2 Missing ⚠️
...-node/src/metrics/eventLoopUtilizationCollector.ts 88.23% 2 Missing ⚠️
...node/src/metrics/heapSpacesSizeAndUsedCollector.ts 94.11% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2136      +/-   ##
==========================================
- Coverage   90.86%   90.79%   -0.07%     
==========================================
  Files         161      169       +8     
  Lines        7858     8009     +151     
  Branches     1612     1632      +20     
==========================================
+ Hits         7140     7272     +132     
- Misses        718      737      +19
Files with missing lines Coverage Δ
...trumentation-runtime-node/src/consts/attributes.ts 100.00% <100.00%> (ø)
...n-runtime-node/src/types/ConventionalNamePrefix.ts 100.00% <100.00%> (ø)
...nstrumentation-runtime-node/src/instrumentation.ts 89.65% <90.00%> (+0.46%) ⬆️
...runtime-node/src/metrics/eventLoopTimeCollector.ts 90.47% <90.47%> (ø)
...-node/src/metrics/eventLoopUtilizationCollector.ts 88.23% <88.23%> (ø)
...node/src/metrics/heapSpacesSizeAndUsedCollector.ts 94.11% <94.11%> (ø)
...untime-node/src/metrics/eventLoopDelayCollector.ts 93.47% <93.47%> (ø)
...entation-runtime-node/src/metrics/baseCollector.ts 66.66% <66.66%> (ø)
...umentation-runtime-node/src/metrics/gcCollector.ts 72.00% <72.00%> (ø)
View more details on Codecov