Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: only publish after release is created #2133

Merged

Conversation

JamieDanielson
Copy link
Member

Which problem is this PR solving?

Short description of the changes

@JamieDanielson JamieDanielson requested a review from a team April 19, 2024 22:10
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Merging #2133 (e19e517) into main (dfb2dff) will decrease coverage by 0.63%.
Report is 62 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2133      +/-   ##
==========================================
- Coverage   90.97%   90.35%   -0.63%     
==========================================
  Files         146      147       +1     
  Lines        7492     7679     +187     
  Branches     1502     1575      +73     
==========================================
+ Hits         6816     6938     +122     
- Misses        676      741      +65     

see 9 files with indirect coverage changes

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks for fixing this 🙌

@pichlermarc pichlermarc merged commit 6c934c3 into open-telemetry:main Apr 22, 2024
15 checks passed
@JamieDanielson JamieDanielson deleted the jamie.fix-publish-step branch April 22, 2024 15:24
pichlermarc added a commit to dynatrace-oss-contrib/opentelemetry-js-contrib that referenced this pull request Apr 25, 2024
pichlermarc added a commit that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ci] newly created packages are published before the release PR is merged
2 participants