docs(resource-detector-alibaba): add Semantic Conventions to alibaba README #2077
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2077 +/- ##
==========================================
- Coverage 90.97% 90.63% -0.34%
==========================================
Files 146 146
Lines 7492 7488 -4
Branches 1502 1494 -8
==========================================
- Hits 6816 6787 -29
- Misses 676 701 +25 |
maryliag
changed the title
Add Semantic Conventions to Alibaba README PArt Of open-telemetry#2025 Signed-off-by: maryliag <[email protected]>
maryliag
changed the title
| | Resource Attribute | Description | Notes | | ||
| |-------------------------|-----------------------------------------------------------------| ------------------------------------------ | | ||
| | cloud.account.id | Value of `owner-account-id` on Alibaba Cloud | Key: `SEMRESATTRS_CLOUD_ACCOUNT_ID` | | ||
| | cloud.availability_zone | Value of `zone-id` on Alibaba Cloud | Key: `SEMRESATTRS_CLOUD_AVAILABILITY_ZONE` | | ||
| | cloud.platform | In this context, it's always `alibaba_cloud_ecs` | Key: `SEMRESATTRS_CLOUD_PLATFORM` | | ||
| | cloud.provider | In this context, it's always `alibaba_cloud` | Key: `SEMRESATTRS_CLOUD_PROVIDER` | | ||
| | cloud.region | Value of `region-id` on Alibaba Cloud | Key: `SEMRESATTRS_CLOUD_REGION` | | ||
| | host.id | Value of `instance-id` on Alibaba Cloud | Key: `SEMRESATTRS_HOST_ID` | | ||
| | host.name | The hostname for the app, retrieve from the `hostname` endpoint | Key: `SEMRESATTRS_HOST_TYPE` | | ||
| | host.type | Value of `instance-type` on Alibaba Cloud | Key: `SEMRESATTRS_HOST_NAME` | |
There was a problem hiding this comment.
Based on comments over on #1778 we may decide not to move forward with this Notes section as it is extra to maintain.
|
sounds good, will close this |
|
Oh! I should note, I think your other section in here referencing the specific semantic convention version is okay to keep - just the Keys in the table are not needed. Want to re-open this or open a new PR for that @maryliag ? The original updates were on #2046 but that was before we started combining the two updates together, so it looks like we still want to mention the version in use in the README. |
|
Ah okay, thanks @JamieDanielson , I created a new PR for it: #2130 |
Which problem is this PR solving?
Short description of the changes