Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(resource-detector-gcp): update readme for gcp resource detector #2062

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

maryliag
Copy link
Contributor

@maryliag maryliag commented Mar 28, 2024

Which problem is this PR solving?

Short description of the changes

  • Update README of GCP Resource Detector to clarify the source of the data and add semantic conventions

@maryliag maryliag requested a review from a team March 28, 2024 16:09
@github-actions github-actions bot requested review from aabmass and punya March 28, 2024 16:25
@maryliag maryliag force-pushed the doc-gcp branch 2 times, most recently from 60fec59 to 43ed36a Compare March 29, 2024 15:43
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Merging #2062 (60ad00a) into main (dfb2dff) will decrease coverage by 0.16%.
Report is 37 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2062      +/-   ##
==========================================
- Coverage   90.97%   90.82%   -0.16%     
==========================================
  Files         146      148       +2     
  Lines        7492     7672     +180     
  Branches     1502     1537      +35     
==========================================
+ Hits         6816     6968     +152     
- Misses        676      704      +28     

see 8 files with indirect coverage changes

@maryliag maryliag force-pushed the doc-gcp branch 3 times, most recently from e05091e to 45ec21b Compare April 3, 2024 13:42
@maryliag maryliag changed the title chore: update readme for gcp resource detector docs(resource-detector-gcp): update readme for gcp resource detector Apr 3, 2024
Update README of GCP Resource Detector to clarify the source of the data and add semantic conventions.

Part Of open-telemetry#2055
Part Of open-telemetry#2025

Signed-off-by: maryliag <[email protected]>
@trentm trentm enabled auto-merge (squash) April 9, 2024 21:02
@trentm trentm merged commit 4da0268 into open-telemetry:main Apr 9, 2024
10 checks passed
@maryliag maryliag deleted the doc-gcp branch April 9, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants