-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(resource-detector-aws): update readme for aws resource detector #2060
Conversation
0b2a8e0
to
1844f22
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2060 +/- ##
==========================================
- Coverage 90.97% 90.82% -0.16%
==========================================
Files 146 148 +2
Lines 7492 7672 +180
Branches 1502 1537 +35
==========================================
+ Hits 6816 6968 +152
- Misses 676 704 +28 |
29f610e
to
a8620e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! I left a few nits around naming capitalization, but at a glance it seems really helpful. I don't know a ton about the attributes to confirm the descriptions.
Update README of AWS Resource Detector to clarifiy the source of the data and add Semantic Conventions. Part Of open-telemetry#2055 Part Of open-telemetry#2025 Signed-off-by: maryliag <[email protected]>
Co-authored-by: Jamie Danielson <[email protected]>
updates made and also remove the notes column |
Which problem is this PR solving?
Short description of the changes