Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update readme for alibaba resource detector #2056

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

maryliag
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Update README of Alibaba resource detector to add a table with values getting detected.

Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it would be great if a link to https://www.alibabacloud.com/help/en/ecs/user-guide/use-instance-identities could be added as well. It helps explaining where values like owner-account-id come from.

@maryliag
Copy link
Contributor Author

Thank you for the review! Link added

Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Update README of Alibaba resource detector to add a table with values getting detected.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Merging #2056 (b3a0387) into main (dfb2dff) will increase coverage by 4.70%.
Report is 20 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2056      +/-   ##
==========================================
+ Coverage   90.97%   95.68%   +4.70%     
==========================================
  Files         146       11     -135     
  Lines        7492      788    -6704     
  Branches     1502      164    -1338     
==========================================
- Hits         6816      754    -6062     
+ Misses        676       34     -642     

see 136 files with indirect coverage changes

@legendecas legendecas merged commit 9976c94 into open-telemetry:main Mar 29, 2024
17 checks passed
@maryliag maryliag deleted the doc-alibaba branch March 29, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants