-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update readme for alibaba resource detector #2056
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it would be great if a link to https://www.alibabacloud.com/help/en/ecs/user-guide/use-instance-identities could be added as well. It helps explaining where values like owner-account-id
come from.
Thank you for the review! Link added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Update README of Alibaba resource detector to add a table with values getting detected. Part Of open-telemetry#2055 Signed-off-by: maryliag <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2056 +/- ##
==========================================
+ Coverage 90.97% 95.68% +4.70%
==========================================
Files 146 11 -135
Lines 7492 788 -6704
Branches 1502 164 -1338
==========================================
- Hits 6816 754 -6062
+ Misses 676 34 -642 |
Which problem is this PR solving?
Short description of the changes