Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(resource-detector-gcp): use exported strings for attributes #2050

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

maryliag
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

On package opentelemetry-resource-detector-gcp:

  • Update @opentelemetry/semantic-conventions from ^1.0.0 to ^1.22.0
  • Use exported strings for Semantic Resource Attributes and Cloud Provider Values.

@maryliag maryliag requested a review from a team March 27, 2024 15:23
@github-actions github-actions bot requested review from aabmass and punya March 27, 2024 15:23
@maryliag maryliag changed the title ichore(resource-detector-gcp): use exported strings for attributes chore(resource-detector-gcp): use exported strings for attributes Mar 27, 2024
@JamieDanielson
Copy link
Member

Just a note, I recently updated the CONTRIBUTING doc because we no longer need to update the changelog on our own in PRs - it gets updated in the releasing step!

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Merging #2050 (1eed9e1) into main (dfb2dff) will decrease coverage by 0.16%.
Report is 39 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2050      +/-   ##
==========================================
- Coverage   90.97%   90.82%   -0.16%     
==========================================
  Files         146      148       +2     
  Lines        7492     7672     +180     
  Branches     1502     1537      +35     
==========================================
+ Hits         6816     6968     +152     
- Misses        676      704      +28     
Files Coverage Δ
...resource-detector-gcp/src/detectors/GcpDetector.ts 96.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

@maryliag
Copy link
Contributor Author

Updated to remove the changes on changelog

@maryliag maryliag force-pushed the update-gcp branch 2 times, most recently from 16ad2eb to 8b3a46f Compare April 2, 2024 13:50
Use exported strings for Semantic Resource Attributes and Cloud Provider Values.

Signed-off-by: maryliag <[email protected]>
@trentm trentm enabled auto-merge (squash) April 9, 2024 22:42
@trentm trentm merged commit 6bd62a2 into open-telemetry:main Apr 9, 2024
4 checks passed
@maryliag maryliag deleted the update-gcp branch April 10, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants