-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(resource-detector-gcp): use exported strings for attributes #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryliag
changed the title
ichore(resource-detector-gcp): use exported strings for attributes
chore(resource-detector-gcp): use exported strings for attributes
Mar 27, 2024
Just a note, I recently updated the CONTRIBUTING doc because we no longer need to update the changelog on our own in PRs - it gets updated in the releasing step! |
59 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2050 +/- ##
==========================================
- Coverage 90.97% 90.82% -0.16%
==========================================
Files 146 148 +2
Lines 7492 7672 +180
Branches 1502 1537 +35
==========================================
+ Hits 6816 6968 +152
- Misses 676 704 +28
|
Updated to remove the changes on changelog |
maryliag
force-pushed
the
update-gcp
branch
2 times, most recently
from
April 2, 2024 13:50
16ad2eb
to
8b3a46f
Compare
Use exported strings for Semantic Resource Attributes and Cloud Provider Values. Signed-off-by: maryliag <[email protected]>
6 tasks
JamieDanielson
approved these changes
Apr 8, 2024
trentm
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
On package
opentelemetry-resource-detector-gcp
:@opentelemetry/semantic-conventions
from^1.0.0
to^1.22.0