Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update deps matching "@opentelemetry/*" #1978

Merged
merged 6 commits into from
Mar 5, 2024
Merged

chore(deps): update deps matching "@opentelemetry/*" #1978

merged 6 commits into from
Mar 5, 2024

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Feb 29, 2024 •
edited
Loading

Update made using the script from #1974

Script output: 
Updating deps matching "@opentelemetry/*" in 59 workspace dirs

Gathering info on outdated deps in each workspace:
 - packages/opentelemetry-host-metrics (1 of 59)
 - packages/opentelemetry-id-generator-aws-xray (2 of 59)
 - packages/opentelemetry-propagation-utils (3 of 59)
 - packages/opentelemetry-redis-common (4 of 59)
 - packages/opentelemetry-sql-common (5 of 59)
 - packages/opentelemetry-test-utils (6 of 59)
 - plugins/node/instrumentation-amqplib (7 of 59)
 - plugins/node/instrumentation-cucumber (8 of 59)
 - plugins/node/instrumentation-dataloader (9 of 59)
 - plugins/node/instrumentation-fs (10 of 59)
 - plugins/node/instrumentation-lru-memoizer (11 of 59)
 - plugins/node/instrumentation-mongoose (12 of 59)
 - plugins/node/instrumentation-runtime-node (13 of 59)
 - plugins/node/instrumentation-socket.io (14 of 59)
 - plugins/node/instrumentation-tedious (15 of 59)
 - plugins/node/opentelemetry-instrumentation-aws-lambda (16 of 59)
 - plugins/node/opentelemetry-instrumentation-aws-sdk (17 of 59)
 - plugins/node/opentelemetry-instrumentation-bunyan (18 of 59)
 - plugins/node/opentelemetry-instrumentation-cassandra (19 of 59)
 - plugins/node/opentelemetry-instrumentation-connect (20 of 59)
 - plugins/node/opentelemetry-instrumentation-dns (21 of 59)
 - plugins/node/opentelemetry-instrumentation-express (22 of 59)
 - plugins/node/opentelemetry-instrumentation-fastify (23 of 59)
 - plugins/node/opentelemetry-instrumentation-generic-pool (24 of 59)
 - plugins/node/opentelemetry-instrumentation-graphql (25 of 59)
 - plugins/node/opentelemetry-instrumentation-hapi (26 of 59)
 - plugins/node/opentelemetry-instrumentation-ioredis (27 of 59)
 - plugins/node/opentelemetry-instrumentation-knex (28 of 59)
 - plugins/node/opentelemetry-instrumentation-koa (29 of 59)
 - plugins/node/opentelemetry-instrumentation-memcached (30 of 59)
 - plugins/node/opentelemetry-instrumentation-mongodb (31 of 59)
 - plugins/node/opentelemetry-instrumentation-mysql (32 of 59)
 - plugins/node/opentelemetry-instrumentation-mysql2 (33 of 59)
 - plugins/node/opentelemetry-instrumentation-nestjs-core (34 of 59)
 - plugins/node/opentelemetry-instrumentation-net (35 of 59)
 - plugins/node/opentelemetry-instrumentation-pg (36 of 59)
 - plugins/node/opentelemetry-instrumentation-pino (37 of 59)
 - plugins/node/opentelemetry-instrumentation-redis-4 (38 of 59)
 - plugins/node/opentelemetry-instrumentation-redis (39 of 59)
 - plugins/node/opentelemetry-instrumentation-restify (40 of 59)
 - plugins/node/opentelemetry-instrumentation-router (41 of 59)
 - plugins/node/opentelemetry-instrumentation-winston (42 of 59)
 - plugins/web/opentelemetry-instrumentation-document-load (43 of 59)
 - plugins/web/opentelemetry-instrumentation-long-task (44 of 59)
 - plugins/web/opentelemetry-instrumentation-user-interaction (45 of 59)
 - plugins/web/opentelemetry-plugin-react-load (46 of 59)
 - propagators/opentelemetry-propagator-aws-xray (47 of 59)
 - propagators/opentelemetry-propagator-grpc-census-binary (48 of 59)
 - propagators/opentelemetry-propagator-instana (49 of 59)
 - propagators/opentelemetry-propagator-ot-trace (50 of 59)
 - detectors/node/opentelemetry-resource-detector-alibaba-cloud (51 of 59)
 - detectors/node/opentelemetry-resource-detector-aws (52 of 59)
 - detectors/node/opentelemetry-resource-detector-azure (53 of 59)
 - detectors/node/opentelemetry-resource-detector-container (54 of 59)
 - detectors/node/opentelemetry-resource-detector-gcp (55 of 59)
 - detectors/node/opentelemetry-resource-detector-github (56 of 59)
 - detectors/node/opentelemetry-resource-detector-instana (57 of 59)
 - metapackages/auto-instrumentations-node (58 of 59)
 - metapackages/auto-instrumentations-web (59 of 59)

Performing updates (43 `npm install ...`s, 1 `npm update ...`):
 $ cd packages/opentelemetry-test-utils && npm install @opentelemetry/[email protected] @opentelemetry/[email protected]
 $ cd plugins/node/instrumentation-amqplib && npm install @opentelemetry/[email protected]
 $ cd plugins/node/instrumentation-cucumber && npm install @opentelemetry/[email protected]
 $ cd plugins/node/instrumentation-dataloader && npm install @opentelemetry/[email protected]
 $ cd plugins/node/instrumentation-fs && npm install @opentelemetry/[email protected]
 $ cd plugins/node/instrumentation-lru-memoizer && npm install @opentelemetry/[email protected]
 $ cd plugins/node/instrumentation-mongoose && npm install @opentelemetry/[email protected]
 $ cd plugins/node/instrumentation-runtime-node && npm install @opentelemetry/[email protected]
 $ cd plugins/node/instrumentation-socket.io && npm install @opentelemetry/[email protected]
 $ cd plugins/node/instrumentation-tedious && npm install @opentelemetry/[email protected]
 $ cd plugins/node/opentelemetry-instrumentation-aws-lambda && npm install @opentelemetry/[email protected]
 $ cd plugins/node/opentelemetry-instrumentation-aws-sdk && npm install @opentelemetry/[email protected]
 $ cd plugins/node/opentelemetry-instrumentation-bunyan && npm install @opentelemetry/[email protected] @opentelemetry/[email protected] @opentelemetry/[email protected]
 $ cd plugins/node/opentelemetry-instrumentation-cassandra && npm install @opentelemetry/[email protected]
 $ cd plugins/node/opentelemetry-instrumentation-connect && npm install @opentelemetry/[email protected]
 $ cd plugins/node/opentelemetry-instrumentation-dns && npm install @opentelemetry/[email protected]
 $ cd plugins/node/opentelemetry-instrumentation-express && npm install @opentelemetry/[email protected]
 $ cd plugins/node/opentelemetry-instrumentation-fastify && npm install @opentelemetry/[email protected] @opentelemetry/[email protected]
 $ cd plugins/node/opentelemetry-instrumentation-generic-pool && npm install @opentelemetry/[email protected]
 $ cd plugins/node/opentelemetry-instrumentation-graphql && npm install @opentelemetry/[email protected]
 $ cd plugins/node/opentelemetry-instrumentation-hapi && npm install @opentelemetry/[email protected]
 $ cd plugins/node/opentelemetry-instrumentation-ioredis && npm install @opentelemetry/[email protected]
 $ cd plugins/node/opentelemetry-instrumentation-knex && npm install @opentelemetry/[email protected]
 $ cd plugins/node/opentelemetry-instrumentation-koa && npm install @opentelemetry/[email protected] @opentelemetry/[email protected]
 $ cd plugins/node/opentelemetry-instrumentation-memcached && npm install @opentelemetry/[email protected]
 $ cd plugins/node/opentelemetry-instrumentation-mongodb && npm install @opentelemetry/[email protected]
 $ cd plugins/node/opentelemetry-instrumentation-mysql && npm install @opentelemetry/[email protected]
 $ cd plugins/node/opentelemetry-instrumentation-mysql2 && npm install @opentelemetry/[email protected]
 $ cd plugins/node/opentelemetry-instrumentation-nestjs-core && npm install @opentelemetry/[email protected]
 $ cd plugins/node/opentelemetry-instrumentation-net && npm install @opentelemetry/[email protected]
 $ cd plugins/node/opentelemetry-instrumentation-pg && npm install @opentelemetry/[email protected]
 $ cd plugins/node/opentelemetry-instrumentation-pino && npm install @opentelemetry/[email protected]
 $ cd plugins/node/opentelemetry-instrumentation-redis-4 && npm install @opentelemetry/[email protected]
 $ cd plugins/node/opentelemetry-instrumentation-redis && npm install @opentelemetry/[email protected]
 $ cd plugins/node/opentelemetry-instrumentation-restify && npm install @opentelemetry/[email protected]
 $ cd plugins/node/opentelemetry-instrumentation-router && npm install @opentelemetry/[email protected]
 $ cd plugins/node/opentelemetry-instrumentation-winston && npm install @opentelemetry/[email protected]
 $ cd plugins/web/opentelemetry-instrumentation-document-load && npm install @opentelemetry/[email protected]
 $ cd plugins/web/opentelemetry-instrumentation-long-task && npm install @opentelemetry/[email protected]
 $ cd plugins/web/opentelemetry-instrumentation-user-interaction && npm install @opentelemetry/[email protected] @opentelemetry/[email protected]
 $ cd detectors/node/opentelemetry-resource-detector-instana && npm install @opentelemetry/[email protected]
 $ cd metapackages/auto-instrumentations-node && npm install @opentelemetry/[email protected] @opentelemetry/[email protected] @opentelemetry/[email protected] @opentelemetry/[email protected]
 $ cd metapackages/auto-instrumentations-web && npm install @opentelemetry/[email protected] @opentelemetry/[email protected] @opentelemetry/[email protected]
 $ npm update @opentelemetry/sdk-metrics @opentelemetry/api @opentelemetry/core @opentelemetry/exporter-jaeger @opentelemetry/resources @opentelemetry/sdk-trace-base @opentelemetry/semantic-conventions @opentelemetry/sdk-trace-node @opentelemetry/context-async-hooks @opentelemetry/sdk-trace-web @opentelemetry/context-zone-peer-dep @opentelemetry/context-zone @opentelemetry/propagator-b3 @opentelemetry/api-logs @opentelemetry/otlp-exporter-base @opentelemetry/exporter-trace-otlp-grpc @opentelemetry/otlp-proto-exporter-base @opentelemetry/exporter-zipkin @opentelemetry/otlp-transformer @opentelemetry/sdk-node @opentelemetry/sdk-logs @opentelemetry/instrumentation @opentelemetry/exporter-trace-otlp-proto @opentelemetry/exporter-trace-otlp-http @opentelemetry/instrumentation-xml-http-request @opentelemetry/instrumentation-fetch @opentelemetry/instrumentation-grpc @opentelemetry/instrumentation-http @opentelemetry/propagator-jaeger @opentelemetry/otlp-grpc-exporter-base

Sanity check that all matching packages are up-to-date:
 $ npm outdated @opentelemetry/sdk-metrics @opentelemetry/api @opentelemetry/core @opentelemetry/contrib-test-utils @opentelemetry/exporter-jaeger @opentelemetry/instrumentation @opentelemetry/sdk-trace-node @opentelemetry/resources @opentelemetry/sdk-node @opentelemetry/sdk-trace-base @opentelemetry/semantic-conventions @opentelemetry/context-async-hooks @opentelemetry/propagator-aws-xray @opentelemetry/propagation-utils @opentelemetry/api-logs @opentelemetry/sdk-logs @opentelemetry/instrumentation-http @opentelemetry/redis-common @opentelemetry/sql-common @opentelemetry/sdk-trace-web @opentelemetry/context-zone-peer-dep @opentelemetry/instrumentation-xml-http-request @opentelemetry/context-zone @opentelemetry/propagator-b3 @opentelemetry/instrumentation-amqplib @opentelemetry/instrumentation-aws-lambda @opentelemetry/instrumentation-aws-sdk @opentelemetry/instrumentation-bunyan @opentelemetry/instrumentation-cassandra-driver @opentelemetry/instrumentation-connect @opentelemetry/instrumentation-cucumber @opentelemetry/instrumentation-dataloader @opentelemetry/instrumentation-dns @opentelemetry/instrumentation-express @opentelemetry/instrumentation-fs @opentelemetry/instrumentation-fastify @opentelemetry/instrumentation-generic-pool @opentelemetry/instrumentation-graphql @opentelemetry/instrumentation-grpc @opentelemetry/instrumentation-hapi @opentelemetry/instrumentation-ioredis @opentelemetry/instrumentation-knex @opentelemetry/instrumentation-koa @opentelemetry/instrumentation-lru-memoizer @opentelemetry/instrumentation-memcached @opentelemetry/instrumentation-mongodb @opentelemetry/instrumentation-mongoose @opentelemetry/instrumentation-mysql @opentelemetry/instrumentation-mysql2 @opentelemetry/instrumentation-nestjs-core @opentelemetry/instrumentation-net @opentelemetry/instrumentation-pg @opentelemetry/instrumentation-pino @opentelemetry/instrumentation-redis @opentelemetry/instrumentation-redis-4 @opentelemetry/instrumentation-restify @opentelemetry/instrumentation-router @opentelemetry/instrumentation-socket.io @opentelemetry/instrumentation-tedious @opentelemetry/instrumentation-winston @opentelemetry/resource-detector-alibaba-cloud @opentelemetry/resource-detector-aws @opentelemetry/resource-detector-container @opentelemetry/resource-detector-gcp @opentelemetry/instrumentation-document-load @opentelemetry/instrumentation-fetch @opentelemetry/instrumentation-user-interaction

Summary of changes (possible commit message):
--
chore(deps): update deps matching "@opentelemetry/*"

    0.48.0 -> 0.49.1 @opentelemetry/api-logs (range-bump)
    0.48.0 -> 0.49.1 @opentelemetry/instrumentation (range-bump)
    0.48.0 -> 0.49.1 @opentelemetry/instrumentation-fetch (range-bump)
    0.48.0 -> 0.49.1 @opentelemetry/instrumentation-grpc (range-bump)
    0.48.0 -> 0.49.1 @opentelemetry/instrumentation-http (range-bump)
    0.48.0 -> 0.49.1 @opentelemetry/instrumentation-xml-http-request (range-bump)
    0.48.0 -> 0.49.1 @opentelemetry/sdk-logs (range-bump)
    0.48.0 -> 0.49.1 @opentelemetry/sdk-node (range-bump)
    0.49.0 -> 0.49.1 @opentelemetry/instrumentation (range-bump)
    0.49.0 -> 0.49.1 @opentelemetry/sdk-node (range-bump)
    1.7.0 -> 1.8.0 @opentelemetry/api
    1.21.0 -> 1.22.0 @opentelemetry/context-async-hooks
    1.21.0 -> 1.22.0 @opentelemetry/context-zone
    1.21.0 -> 1.22.0 @opentelemetry/context-zone-peer-dep
    1.21.0 -> 1.22.0 @opentelemetry/core
    1.21.0 -> 1.22.0 @opentelemetry/exporter-jaeger
    1.21.0 -> 1.22.0 @opentelemetry/propagator-b3
    1.21.0 -> 1.22.0 @opentelemetry/resources
    1.21.0 -> 1.22.0 @opentelemetry/sdk-metrics
    1.21.0 -> 1.22.0 @opentelemetry/sdk-trace-base
    1.21.0 -> 1.22.0 @opentelemetry/sdk-trace-node
    1.21.0 -> 1.22.0 @opentelemetry/sdk-trace-web
    1.21.0 -> 1.22.0 @opentelemetry/semantic-conventions
--

BEGIN_COMMIT_OVERRIDE
feat(deps): update otel-js to 1.22.0/0.49.1
END_COMMIT_OVERRIDE

@pichlermarc
chore(deps): update deps matching "@opentelemetry/*"
c931fce 
    0.48.0 -> 0.49.1 @opentelemetry/api-logs (range-bump)
    0.48.0 -> 0.49.1 @opentelemetry/instrumentation (range-bump)
    0.48.0 -> 0.49.1 @opentelemetry/instrumentation-fetch (range-bump)
    0.48.0 -> 0.49.1 @opentelemetry/instrumentation-grpc (range-bump)
    0.48.0 -> 0.49.1 @opentelemetry/instrumentation-http (range-bump)
    0.48.0 -> 0.49.1 @opentelemetry/instrumentation-xml-http-request (range-bump)
    0.48.0 -> 0.49.1 @opentelemetry/sdk-logs (range-bump)
    0.48.0 -> 0.49.1 @opentelemetry/sdk-node (range-bump)
    0.49.0 -> 0.49.1 @opentelemetry/instrumentation (range-bump)
    0.49.0 -> 0.49.1 @opentelemetry/sdk-node (range-bump)
    1.7.0 -> 1.8.0 @opentelemetry/api
    1.21.0 -> 1.22.0 @opentelemetry/context-async-hooks
    1.21.0 -> 1.22.0 @opentelemetry/context-zone
    1.21.0 -> 1.22.0 @opentelemetry/context-zone-peer-dep
    1.21.0 -> 1.22.0 @opentelemetry/core
    1.21.0 -> 1.22.0 @opentelemetry/exporter-jaeger
    1.21.0 -> 1.22.0 @opentelemetry/propagator-b3
    1.21.0 -> 1.22.0 @opentelemetry/resources
    1.21.0 -> 1.22.0 @opentelemetry/sdk-metrics
    1.21.0 -> 1.22.0 @opentelemetry/sdk-trace-base
    1.21.0 -> 1.22.0 @opentelemetry/sdk-trace-node
    1.21.0 -> 1.22.0 @opentelemetry/sdk-trace-web
    1.21.0 -> 1.22.0 @opentelemetry/semantic-conventions
@codecov Codecov
Copy link

codecov bot commented Mar 1, 2024 •
edited
Loading

Codecov Report

Merging #1978 (e7374ec) into main (fef1b36) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1978   +/-   ##
=======================================
  Coverage   91.02%   91.03%           
=======================================
  Files         146      146           
  Lines        7491     7492    +1     
  Branches     1501     1501           
=======================================
+ Hits         6819     6820    +1     
  Misses        672      672
Files Coverage Δ
...ce-detector-aws/src/detectors/AwsLambdaDetector.ts 100.00% <100.00%> (ø)
...y-instrumentation-aws-sdk/src/services/dynamodb.ts 100.00% <100.00%> (ø)
...emetry-instrumentation-aws-sdk/src/services/sns.ts 94.11% <100.00%> (ø)
...emetry-instrumentation-aws-sdk/src/services/sqs.ts 100.00% <100.00%> (ø)
...opentelemetry-instrumentation-redis-4/src/utils.ts 83.33% <100.00%> (+0.98%) ⬆️

@pichlermarc pichlermarc marked this pull request as ready for review March 1, 2024 08:15
@pichlermarc pichlermarc requested a review from a team March 1, 2024 08:15
@pichlermarc
Copy link
Member Author

pichlermarc commented Mar 1, 2024 •
edited
Loading

The only thing failing here seems to be [email protected] which was just recently (15 hours ago) released. The problem is likely not related to this PR but is the instrumentation misbehaving with that version.

Re-running tests on main to verify.
https://github.com/open-telemetry/opentelemetry-js-contrib/actions/runs/8093744773/job/22167022286

@pichlermarc pichlermarc mentioned this pull request Mar 1, 2024
Closed
@pichlermarc
Copy link
Member Author

Failing TAV tests are also happening on main, see #1983
Checked locally and it the problem is related to [email protected] being released yesterday.

All other tests are passing (see test logs).

@drewcorlin1 drewcorlin1 mentioned this pull request Mar 2, 2024
Closed
@trentm trentm mentioned this pull request Mar 5, 2024
Merged
trentm
trentm approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pichlermarc pichlermarc merged commit edc426b into open-telemetry:main Mar 5, 2024
15 of 17 checks passed
@pichlermarc pichlermarc deleted the chore/update-dependencies branch March 5, 2024 11:46
@pichlermarc pichlermarc added the dependencies Pull requests that update a dependency file label Mar 5, 2024
@pichlermarc pichlermarc mentioned this pull request Mar 6, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentm trentm trentm approved these changes

Assignees

@basti1302 basti1302

@kirrg001 kirrg001

@dyladan dyladan

@martinkuba martinkuba

@legendecas legendecas

@blumamir blumamir

@naseemkullah naseemkullah

@mottibec mottibec

@JamieDanielson JamieDanielson

@haddasbronfman haddasbronfman

Labels
dependencies Pull requests that update a dependency file pkg:auto-instrumentations-node pkg:auto-instrumentations-web pkg:instrumentation-amqplib pkg:instrumentation-aws-lambda pkg:instrumentation-aws-sdk pkg:instrumentation-bunyan pkg:instrumentation-cassandra-driver pkg:instrumentation-connect pkg:instrumentation-cucumber pkg:instrumentation-dataloader pkg:instrumentation-dns pkg:instrumentation-document-load pkg:instrumentation-express pkg:instrumentation-fastify pkg:instrumentation-fs pkg:instrumentation-generic-pool pkg:instrumentation-graphql pkg:instrumentation-hapi pkg:instrumentation-ioredis pkg:instrumentation-knex pkg:instrumentation-koa pkg:instrumentation-long-task pkg:instrumentation-lru-memoizer pkg:instrumentation-memcached pkg:instrumentation-mongodb pkg:instrumentation-mongoose pkg:instrumentation-mysql pkg:instrumentation-mysql2 pkg:instrumentation-nestjs-core pkg:instrumentation-net pkg:instrumentation-pg pkg:instrumentation-pino pkg:instrumentation-redis pkg:instrumentation-redis-4 pkg:instrumentation-restify pkg:instrumentation-router pkg:instrumentation-runtime-node pkg:instrumentation-socket.io pkg:instrumentation-tedious pkg:instrumentation-user-interaction pkg:instrumentation-winston pkg:propagation-utils pkg:resource-detector-alibaba-cloud pkg:resource-detector-aws pkg:resource-detector-azure pkg:resource-detector-container pkg:resource-detector-gcp pkg:resource-detector-instana pkg:sampler-aws-xray pkg:test-utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.