Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: new version with TextMapPropagator interface #196

Merged
merged 2 commits into from
Sep 7, 2020

Conversation

jufab
Copy link
Contributor

@jufab jufab commented Sep 3, 2020

Which problem is this PR solving?

  • new TextMapPropagator interface (JaegerHttpTracePropagator and GrpcCensusPropagator)

Short description of the changes

  • Use lastest version of opentelemetry-js (0.11.0) and replace HttpTextPropagator with TextMapPropagator.
  • Change Context Object on GrpcCensusPropagator test.
  • Delete useless devDependencies

@jufab jufab requested a review from a team September 3, 2020 00:32
@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #196 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
- Coverage   95.22%   95.22%   -0.01%     
==========================================
  Files          93       93              
  Lines        4751     4750       -1     
  Branches      492      492              
==========================================
- Hits         4524     4523       -1     
  Misses        227      227              
Impacted Files Coverage Δ
...tor-grpc-census-binary/src/GrpcCensusPropagator.ts 100.00% <100.00%> (ø)
...pc-census-binary/test/GrpcCensusPropagator.test.ts 94.44% <100.00%> (-0.07%) ⬇️

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@obecny obecny added the enhancement New feature or request label Sep 7, 2020
@obecny obecny merged commit 16d3515 into open-telemetry:master Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants