redis cleanup

[naseemkullah]

Which problem is this PR solving?

• n/a

Short description of the changes

• Removing unneeded type RedisPluginStreamTypes
• only import required type from redis where applicable
• prefer import type where applicable

[codecov]

Codecov Report

Merging #195 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
- Coverage   95.29%   95.22%   -0.08%     
==========================================
  Files          88       93       +5     
  Lines        4381     4750     +369     
  Branches      478      492      +14     
==========================================
+ Hits         4175     4523     +348     
- Misses        206      227      +21     

Impacted Files	Coverage Δ
node/opentelemetry-plugin-redis/src/utils.ts	90.90% <0.00%> (ø)
node/opentelemetry-plugin-ioredis/.eslintrc.js	0.00% <0.00%> (ø)
node/opentelemetry-plugin-ioredis/src/ioredis.ts	100.00% <0.00%> (ø)
node/opentelemetry-plugin-ioredis/src/utils.ts	85.36% <0.00%> (ø)
node/opentelemetry-plugin-ioredis/src/version.ts	100.00% <0.00%> (ø)
.../opentelemetry-plugin-ioredis/test/ioredis.test.ts	95.30% <0.00%> (ø)

[obecny]

I would prefer to just add type for all imports

import type * as redisTypes from 'redis'

without really changing redisTypes into redis and be consistent everywhere so avoid things like

import type { Callback } from 'redis';

but rather have

import type * as redisTypes from 'redis'

// and then 
callback: redisTypes.Callback<unknown>;

It is much more intuitive to see something like redisTypes.Callback instead of Callback or later
redisTypes.RedisClient instead of RedisClient mixed with RedisPluginClientTypes and trying to figure out which type comes from where

[naseemkullah]

I would prefer to just add type for all imports

import type * as redisTypes from 'redis'

without really changing redisTypes into redis and be consistent everywhere so avoid things like

import type { Callback } from 'redis';

but rather have

import type * as redisTypes from 'redis'

// and then 
callback: redisTypes.Callback<unknown>;

It is much more intuitive to see something like redisTypes.Callback instead of Callback or later
redisTypes.RedisClient instead of RedisClient mixed with RedisPluginClientTypes and trying to figure out which type comes from where

Alright I've adjusted as requested.

[obecny]

lgtm, thx