Zone.js fixed failing build #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@open-telemetry/javascript-approvers guys any idea why is this failing and since when it could be a problem with our build ? |
|
I believe this one was the first issue talking about that, no idea why though. |
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
=======================================
Coverage 95.23% 95.23%
=======================================
Files 93 93
Lines 4767 4767
Branches 493 493
=======================================
Hits 4540 4540
Misses 227 227 |
|
@open-telemetry/javascript-approvers seems like fixed, pls approve so I can merge it and use in other failing builds |
vmarchaud
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing failing build