fix(express): listen for finish event on response for async express layer #107
#188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmarchaud
added
the
size/S
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
==========================================
+ Coverage 95.21% 95.26% +0.05%
==========================================
Files 92 87 -5
Lines 4723 4541 -182
Branches 488 476 -12
==========================================
- Hits 4497 4326 -171
+ Misses 226 215 -11 |
obecny
approved these changes
Sep 1, 2020
vmarchaud
force-pushed
the
fix-express-async-layer
branch
from
e97aa05 to
7c8f8fe
Compare
|
@obecny Sorry for the force push, i didn't saw your review and wanted to make a review before someone would do one :/ |
dyladan
approved these changes
Sep 9, 2020
|
This PR has been open for a while now and it contains a important bug fix, can we merge it or do we need more review ? |
naseemkullah
approved these changes
Sep 13, 2020
vmarchaud
force-pushed
the
fix-express-async-layer
branch
from
1a0014c to
6d23d61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was hesitant of implement it like this from the start (for performance reason since we are adding a listener for every async layer) but seeing the half-broken (timing are not accurate) spans reporting, i think it's better like this for end user.