Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mongodb] implement semantic db conventions #187

Merged
merged 3 commits into from
Sep 1, 2020

Conversation

naseemkullah
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • adhering to spec, worth noting: split ns to populate db.name and db.mongodb.collection attributes

@naseemkullah naseemkullah requested review from vmarchaud and a team August 28, 2020 18:48
@dyladan dyladan changed the title feat: implement semantic db conventions [mongodb] implement semantic db conventions Aug 28, 2020
@dyladan dyladan added the enhancement New feature or request label Aug 28, 2020
Copy link
Member

@markwolff markwolff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

plugins/node/opentelemetry-plugin-mongodb/src/mongodb.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 31, 2020

Codecov Report

Merging #187 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
- Coverage   95.23%   95.22%   -0.02%     
==========================================
  Files          93       93              
  Lines        4767     4756      -11     
  Branches      493      492       -1     
==========================================
- Hits         4540     4529      -11     
  Misses        227      227              
Impacted Files Coverage Δ
node/opentelemetry-plugin-mongodb/src/types.ts 100.00% <0.00%> (ø)
node/opentelemetry-plugin-mongodb/test/utils.ts 91.17% <0.00%> (ø)
node/opentelemetry-plugin-mongodb/src/mongodb.ts 95.83% <0.00%> (ø)

@obecny
Copy link
Member

obecny commented Aug 31, 2020

@naseemkullah pls have a loot why is it failing - looks like might be a valid failures now ?

It could be a string or an instance of MongoDBNamespace

Signed-off-by: Naseem <[email protected]>
@naseemkullah
Copy link
Member Author

Thanks @obecny

Seems like the namespace can be a MongoDBNamespace which is not available in definitely typed. In any case, always coercing to a string seems to have fixed the issue.

@obecny obecny merged commit 2915c43 into open-telemetry:master Sep 1, 2020
@naseemkullah naseemkullah deleted the mongodb-semantic-db branch September 2, 2020 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants