-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mongodb] implement semantic db conventions #187
[mongodb] implement semantic db conventions #187
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
==========================================
- Coverage 95.23% 95.22% -0.02%
==========================================
Files 93 93
Lines 4767 4756 -11
Branches 493 492 -1
==========================================
- Hits 4540 4529 -11
Misses 227 227
|
@naseemkullah pls have a loot why is it failing - looks like might be a valid failures now ? |
Signed-off-by: Naseem <[email protected]>
…tting attributes Signed-off-by: Naseem <[email protected]>
13c2694
to
f3d95e3
Compare
It could be a string or an instance of MongoDBNamespace Signed-off-by: Naseem <[email protected]>
Thanks @obecny Seems like the namespace can be a MongoDBNamespace which is not available in definitely typed. In any case, always coercing to a string seems to have fixed the issue. |
Which problem is this PR solving?
Short description of the changes
ns
to populatedb.name
anddb.mongodb.collection
attributes