chore(instrumentation-mongoose, instrumentation-socket.io)!: bump engines from >=14.0 to >=14 #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ines from >=14.0 to >=14 This bump means that the minimum supported Node.js version is vague about the minor. '>=14' is used in all other instrumentations. CI only tests with the current latest Node.js v14.x.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1843 +/- ##
=======================================
Coverage 91.45% 91.45%
=======================================
Files 144 144
Lines 7406 7406
Branches 1483 1483
=======================================
Hits 6773 6773
Misses 633 633 |
Merged
kirrg001
added a commit
to instana/nodejs
that referenced
this pull request
May 7, 2024
kirrg001
added a commit
to instana/nodejs
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bump means that the minimum supported Node.js version is vague
about the minor. '>=14' is used in all other instrumentations. CI only
tests with the current latest Node.js v14.x.
Mainly this is to get the "engines" entry in these two instrumentations to be the same as for all the other instrumentations. Also, it means that the bump to mongoose@7 in #1825 won't be quite so awkward: mongoose@7 supports
>=14.20.1:https://github.com/Automattic/mongoose/blob/7.x/package.json#L122-L124
I don't think effectively changes the supported minimum Node.js version, because my guess is that if an issue came in for instrumentation-mongoose that only affected an old 14.0.x (Node.js 14.0.0 was released Apr 22, 2020), but not recent 14.x versions, that the first suggestion/request would be to update to a recent 14.x.