chore(instrumentation-mysql2): drop unneed @types/mysql2 dep (bad PR, see 1812) #1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ugh, sorry, I made this PR from my main branch instead of a feature branch. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1811 +/- ##
==========================================
+ Coverage 91.42% 96.06% +4.63%
==========================================
Files 143 14 -129
Lines 7303 914 -6389
Branches 1461 199 -1262
==========================================
- Hits 6677 878 -5799
+ Misses 626 36 -590 |
Superseded by #1812 |
trentm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types are included in 'mysql2' now (as of some 2.x release).
The github:types/mysql2 dependency is problematic for dependabot version updates.
See: #1806 (comment)