Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sync package-lock file to package.json files #1807

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

trentm
Copy link
Contributor

@trentm trentm commented Nov 16, 2023

This PR was generated from running npm install --package-lock-only. It undoes part of the change by renovate in #1723.
See discussion at #1806

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #1807 (81ea8df) into main (5c1050b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1807   +/-   ##
=======================================
  Coverage   91.42%   91.42%           
=======================================
  Files         143      143           
  Lines        7303     7303           
  Branches     1461     1461           
=======================================
  Hits         6677     6677           
  Misses        626      626           

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR (feel free to put it out of draft anytime to get it merged) - looks like we may actually need a non-existent (?) renovate feature that would allow us to group in lock file maintainance with update PRs.

I'll put some more thoughts on the issue #1806

@trentm trentm marked this pull request as ready for review November 17, 2023 13:39
@trentm trentm requested a review from a team November 17, 2023 13:39
@pichlermarc pichlermarc merged commit a034982 into open-telemetry:main Nov 20, 2023
13 checks passed
@trentm trentm deleted the tm-sync-package-lock-file branch November 20, 2023 18:16
jmcdo29 pushed a commit to jmcdo29/opentelemetry-js-contrib that referenced this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants