-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(opentelemetry-plugin-pg): omit pg.values by default #174
Conversation
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
==========================================
+ Coverage 94.23% 94.30% +0.07%
==========================================
Files 76 77 +1
Lines 3766 3830 +64
Branches 406 413 +7
==========================================
+ Hits 3549 3612 +63
- Misses 217 218 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like great work thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Which problem is this PR solving?
This PR solves issue #11, that reports the PostgreSQL plugin must not log
pg.values
by default because they may contain sensitive data such as user credentials.Short description of the changes
PgClientExtended
type to inherit directly frompgTypes.Client
instead of intersect them all the time.utils.ts
to avoid generic types (...args: unknown[]
)PgPluginQueryConfig
interface toNormalizedQueryConfig
(based on the plugin) to avoid confusion.pg.values
only whenenhancedDatabaseReporting
(standard property) flag is se to true.utils.ts
instead of duplicating the assertions for each valid call.