-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Plugin User Interaction]: Improve causality of spans from bubbled events #172
Conversation
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
=======================================
Coverage 94.30% 94.31%
=======================================
Files 77 77
Lines 3830 3836 +6
Branches 413 415 +2
=======================================
+ Hits 3612 3618 +6
Misses 218 218
|
plugins/web/opentelemetry-plugin-user-interaction/src/userInteraction.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel Dyla <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me by I'm not an expert on this plugin. Would like to get @obecny feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm, I just would like to ask you to update the image images/main-sync.jpg
to show how the trace will look like now after this change.
plugins/web/opentelemetry-plugin-user-interaction/src/userInteraction.ts
Outdated
Show resolved
Hide resolved
There's no difference in the examples because of this change - this only affects scenarios where event listeners on bubbling events are added at multiple levels of the DOM tree, which the examples don't do. |
Which problem is this PR solving?
Short description of the changes