-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(koa): Skip update HTTP's span name and update RpcMetadata's route instead #1567
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1567 +/- ##
==========================================
- Coverage 96.06% 91.77% -4.29%
==========================================
Files 14 139 +125
Lines 914 7110 +6196
Branches 199 1426 +1227
==========================================
+ Hits 878 6525 +5647
- Misses 36 585 +549
|
can we merge this or add pkg:instrumentation-koa label so we can test tav for this? |
This one is ready to merge, but the build seems to have an issue
Can you please take a look? |
My bad, forgot to remove unused import. |
Which problem is this PR solving?
Each framework has a different approach to updating Span's name and HTTP_ROUTE attribute. We want to delegate this to instrumentation-http for consistent's name and attribute
This PR fixes the above issue for koa when integrate with @koa/router as koa are not support routing natively.
Short description of the changes