Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(GHA): Update the usage of set-output command in GH actions #1296

Merged
merged 2 commits into from
Jan 2, 2023
Merged

chore(GHA): Update the usage of set-output command in GH actions #1296

merged 2 commits into from
Jan 2, 2023

Conversation

vasireddy99
Copy link
Contributor

@vasireddy99 vasireddy99 commented Nov 21, 2022 •
edited
Loading

This PR updates the usage of set-output command in GH actions.

Reference : https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

ChangeLog entry is not required

@vasireddy99 vasireddy99 requested a review from a team November 21, 2022 11:57
@vasireddy99 vasireddy99 changed the title Update the usage of set-output command in GH actions chore(GHA): Update the usage of set-output command in GH actions Nov 21, 2022
@codecov
Copy link

codecov bot commented Nov 21, 2022 •
edited
Loading

Codecov Report

Merging #1296 (c0715f1) into main (cd9984a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1296   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files          14       14           
  Lines         893      893           
  Branches      191      191           
=======================================
  Hits          858      858           
  Misses         35       35

@blumamir
Copy link
Member

Thanks
Seems CI now fails when running this job.
Can you please take a look?

@vasireddy99
Copy link
Contributor Author

Thanks
Seems CI now fails when running this job.
Can you please take a look?

yes for sure, fixed the PR build should be good for review 🙂

blumamir
blumamir approved these changes Jan 1, 2023
View reviewed changes
Copy link
Member

@blumamir blumamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 💯

@blumamir
Copy link
Member

blumamir commented Jan 1, 2023

Please rebase this branch so I can merge, or "allow edits from maintainers" so we can rebase and merge on one go

@blumamir blumamir merged commit 72e961c into open-telemetry:main Jan 2, 2023
@vasireddy99 vasireddy99 deleted the set-output branch January 3, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blumamir blumamir blumamir approved these changes

@pichlermarc pichlermarc pichlermarc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vasireddy99 @blumamir @pichlermarc