Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove NathanielRN from component owner #1234

Merged
merged 2 commits into from
Oct 20, 2022

Conversation

blumamir
Copy link
Member

This PR updates the component owner for aws packages.
According to @willarmiros , @NathanielRN is no longer working on the project.

@blumamir blumamir requested a review from a team October 19, 2022 06:58
@github-actions github-actions bot requested a review from willarmiros October 19, 2022 06:58
@blumamir blumamir requested a review from NathanielRN October 19, 2022 06:58
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #1234 (1a65e14) into main (180b336) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1234      +/-   ##
==========================================
- Coverage   96.08%   96.05%   -0.03%     
==========================================
  Files          14       23       +9     
  Lines         893     1090     +197     
  Branches      191      203      +12     
==========================================
+ Hits          858     1047     +189     
- Misses         35       43       +8     
Impacted Files Coverage Δ
...etapackages/auto-instrumentations-web/src/utils.ts
...emetry-propagator-instana/src/InstanaPropagator.ts
...umentation-user-interaction/src/instrumentation.ts
...trumentation-document-load/src/enums/EventNames.ts
...etry-plugin-react-load/src/enums/AttributeNames.ts
...ation-user-interaction/src/enums/AttributeNames.ts
...lemetry-instrumentation-document-load/src/utils.ts
...strumentation-document-load/src/instrumentation.ts
...entation-document-load/src/enums/AttributeNames.ts
...lugin-react-load/src/BaseOpenTelemetryComponent.ts
... and 23 more

Copy link
Contributor

@NathanielRN NathanielRN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Thanks for letting me help while I could 🙂

@blumamir blumamir merged commit 1d5a2a9 into open-telemetry:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants