Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update experimental Otel deps to ^0.31.0 #1096

Merged
merged 7 commits into from
Aug 9, 2022

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Jul 21, 2022

Which problem is this PR solving?

Avoid duplicates of e.g. @opentelemetry/instrumentation.

Short description of the changes

Depend on ^0.31.0 for experimental OTel packages because ^0.29.2 doesn't pick up 0.31.
This avoids duplicates of e.g. @opentelemetry/instrumentation in case latest is requested via
app package.json.

Checklist

  • Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

@Flarna
Copy link
Member Author

Flarna commented Jul 21, 2022

There seems to be some dependency issue in opentelemetry-resource-detector-github resulting in failing builds:

> @opentelemetry/[email protected] compile /home/runner/work/opentelemetry-js-contrib/opentelemetry-js-contrib/detectors/node/opentelemetry-resource-detector-github
> tsc -p .
error TS2688: Cannot find type definition file for 'parse5'.
  The file is in the program because:
    Entry point for implicit type library 'parse5'
../../../node_modules/@types/jsdom/base.d.ts:4:33 - error TS7016: Could not find a declaration file for module 'parse5'. '/home/runner/work/opentelemetry-js-contrib/opentelemetry-js-contrib/node_modules/parse5/lib/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/parse5` if it exists or add a new declaration (.d.ts) file containing `declare module 'parse5';`
4 import { ElementLocation } from "parse5"

@smithclay I think you added this detector but you are not mentioned as owner in https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/.github/component_owners.yml.
Do you feel still responsible for it? Any hints how to fix this?

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #1096 (9141212) into main (a099c41) will decrease coverage by 4.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1096      +/-   ##
==========================================
- Coverage   96.07%   92.00%   -4.08%     
==========================================
  Files          14      121     +107     
  Lines         892     5978    +5086     
  Branches      191     1171     +980     
==========================================
+ Hits          857     5500    +4643     
- Misses         35      478     +443     
Impacted Files Coverage Δ
...nstrumentation-express/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
plugins/node/instrumentation-tedious/src/utils.ts 88.23% <0.00%> (ø)
...ource-detector-aws/src/detectors/AwsEksDetector.ts 91.25% <0.00%> (ø)
packages/opentelemetry-host-metrics/src/util.ts 91.66% <0.00%> (ø)
...etry-instrumentation-router/src/instrumentation.ts 96.15% <0.00%> (ø)
...ry-resource-detector-docker/src/detectors/index.ts 100.00% <0.00%> (ø)
...umentation-nestjs-core/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...opentelemetry-instrumentation-aws-sdk/src/utils.ts 97.36% <0.00%> (ø)
...emetry-instrumentation-hapi/src/instrumentation.ts 99.30% <0.00%> (ø)
...de/opentelemetry-instrumentation-hapi/src/types.ts 100.00% <0.00%> (ø)
... and 97 more

@Flarna Flarna marked this pull request as draft August 5, 2022 08:40
@Flarna
Copy link
Member Author

Flarna commented Aug 5, 2022

back to draft as 0.30.0 is already outdated

@Flarna Flarna force-pushed the deps-exerimental branch from d9d3043 to b59e26c Compare August 5, 2022 13:11
@Flarna Flarna changed the title feat: update experimental Otel deps to 0.30.0 feat: update experimental Otel deps to ^0.31.0 Aug 5, 2022
Depend on ^0.31.0 for experimental OTel packages because ^0.29.2 doesn't pick up 0.31.x.
This avoids duplicates of e.g. @opentelemetry/instrumentation in case latest is requested via
app package.json.
@Flarna Flarna force-pushed the deps-exerimental branch from b59e26c to ebcf0e3 Compare August 5, 2022 13:13
@Flarna Flarna marked this pull request as ready for review August 5, 2022 13:29
@vmarchaud vmarchaud requested a review from a team August 5, 2022 14:38
@dyladan
Copy link
Member

dyladan commented Aug 5, 2022

I'm going to hold this until I can release the packages that have already been updated. #1112 is blocking that so please review that so we can get the previous release finished and we can get this through

@dyladan
Copy link
Member

dyladan commented Aug 9, 2022

Going to merge this but i'd like to do #1113 first since this touches so many packages. Would appreciate a review there.

@dyladan dyladan merged commit 4c8843b into open-telemetry:main Aug 9, 2022
@dyladan dyladan mentioned this pull request Aug 9, 2022
@Flarna Flarna deleted the deps-exerimental branch August 10, 2022 08:42
@dyladan dyladan mentioned this pull request Jan 2, 2023
@dyladan dyladan mentioned this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants